Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2898773002: Prevent Feedback's top bar from being chopped when a large font is used (Closed)

Created:
3 years, 7 months ago by afakhry
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, apacible+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent Feedback's top bar from being chopped when a large font is used Sets a minimum height for the top bar of the feedback app so that it doesn't get chopped when font settings are set to a large size. BUG=722243 TEST=Manually, set minimum font size to large from system settings, and open the feedback app. The title bar should not be chopped. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2898773002 Cr-Commit-Position: refs/heads/master@{#473659} Committed: https://chromium.googlesource.com/chromium/src/+/b5e4ad6bc83bdbfc3865e0b8d4e61e8c2bef681c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/feedback/css/feedback.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
afakhry
Xiyuan, please review. Thank you!
3 years, 7 months ago (2017-05-22 17:35:10 UTC) #3
xiyuan
lgtm
3 years, 7 months ago (2017-05-22 18:17:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898773002/1
3 years, 7 months ago (2017-05-22 18:20:09 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 19:47:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5e4ad6bc83bdbfc3865e0b8d4e6...

Powered by Google App Engine
This is Rietveld 408576698