Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2898763004:
PlzNavigateNavigationHandleImplBrowserTest.BlockedRequestAfterWebUI (Closed)
|
Created:
3 years, 7 months ago by ncarter (slow) Modified:
3 years, 6 months ago Reviewers:
nasko CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPlzNavigateNavigationHandleImplBrowserTest.BlockedRequestAfterWebUI
Tests the case where a browser-initiated navigation to a normal webpage is
blocked (net::ERR_BLOCKED_BY_CLIENT) while departing from a privileged WebUI
page (chrome://gpu). It is a security risk for the error page to commit in
the privileged process.
BUG=661324
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2898763004
Cr-Commit-Position: refs/heads/master@{#474356}
Committed: https://chromium.googlesource.com/chromium/src/+/be2ecca29e9914527c5ee5deaceefd02646a3b72
Patch Set 1 #Patch Set 2 : Move test to content #Patch Set 3 : Move test to content #Patch Set 4 : web_contents #
Total comments: 2
Messages
Total messages: 20 (15 generated)
Description was changed from ========== Add a chrome navigation browser test, BlockedWhileLeavingWebUI, that ensures we don't crash when a throttle-blocked navigation occurs while the current page is WebUI. BUG= ========== to ========== Add a chrome navigation browser test, BlockedWhileLeavingWebUI, that ensures we don't crash when a throttle-blocked navigation occurs while the current page is WebUI. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by nick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add a chrome navigation browser test, BlockedWhileLeavingWebUI, that ensures we don't crash when a throttle-blocked navigation occurs while the current page is WebUI. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== PlzNavigateNavigationHandleImplBrowserTest.BlockedRequestAfterWebUI Tests the case where a browser-initiated navigation to a normal webpage is blocked (net::ERR_BLOCKED_BY_CLIENT) while departing from a privileged WebUI page (chrome://gpu). It is a security risk for the error page to commit in the privileged process. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== PlzNavigateNavigationHandleImplBrowserTest.BlockedRequestAfterWebUI Tests the case where a browser-initiated navigation to a normal webpage is blocked (net::ERR_BLOCKED_BY_CLIENT) while departing from a privileged WebUI page (chrome://gpu). It is a security risk for the error page to commit in the privileged process. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== PlzNavigateNavigationHandleImplBrowserTest.BlockedRequestAfterWebUI Tests the case where a browser-initiated navigation to a normal webpage is blocked (net::ERR_BLOCKED_BY_CLIENT) while departing from a privileged WebUI page (chrome://gpu). It is a security risk for the error page to commit in the privileged process. BUG=661324 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
nick@chromium.org changed reviewers: + nasko@chromium.org
nasko, please review This is a browser test that more directly exercises the bug fixed by r472303.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM with a nit. https://codereview.chromium.org/2898763004/diff/60001/content/browser/frame_h... File content/browser/frame_host/navigation_handle_impl_browsertest.cc (right): https://codereview.chromium.org/2898763004/diff/60001/content/browser/frame_h... content/browser/frame_host/navigation_handle_impl_browsertest.cc:1295: scoped_refptr<SiteInstance> web_ui_process = web_contents->GetSiteInstance(); nit: web_ui_site_instance?
https://codereview.chromium.org/2898763004/diff/60001/content/browser/frame_h... File content/browser/frame_host/navigation_handle_impl_browsertest.cc (right): https://codereview.chromium.org/2898763004/diff/60001/content/browser/frame_h... content/browser/frame_host/navigation_handle_impl_browsertest.cc:1295: scoped_refptr<SiteInstance> web_ui_process = web_contents->GetSiteInstance(); On 2017/05/23 04:48:53, nasko wrote: > nit: web_ui_site_instance? The name was intentional, to highlight the importance of doing a process transfer. The reader knows what a process is, but may not know what a SiteInstance is. This is a breadcrumb to aid understanding.
The CQ bit was checked by nick@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495646308389680,
"parent_rev": "78e10e9f196add35245bba8e7b74b1baa7085072", "commit_rev":
"be2ecca29e9914527c5ee5deaceefd02646a3b72"}
Message was sent while issue was closed.
Description was changed from ========== PlzNavigateNavigationHandleImplBrowserTest.BlockedRequestAfterWebUI Tests the case where a browser-initiated navigation to a normal webpage is blocked (net::ERR_BLOCKED_BY_CLIENT) while departing from a privileged WebUI page (chrome://gpu). It is a security risk for the error page to commit in the privileged process. BUG=661324 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== PlzNavigateNavigationHandleImplBrowserTest.BlockedRequestAfterWebUI Tests the case where a browser-initiated navigation to a normal webpage is blocked (net::ERR_BLOCKED_BY_CLIENT) while departing from a privileged WebUI page (chrome://gpu). It is a security risk for the error page to commit in the privileged process. BUG=661324 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2898763004 Cr-Commit-Position: refs/heads/master@{#474356} Committed: https://chromium.googlesource.com/chromium/src/+/be2ecca29e9914527c5ee5deacee... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/be2ecca29e9914527c5ee5deacee... |
