Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2898673003: Split DragEvent back out from MouseEvent (Closed)

Created:
3 years, 7 months ago by Alan Knight
Modified:
3 years, 7 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org, keertip
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -216 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 2 chunks +17 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 34 chunks +103 lines, -71 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 36 chunks +130 lines, -91 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 2 chunks +21 lines, -21 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 2 chunks +21 lines, -21 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmleventgenerator.py View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Alan Knight
We combined DragEvent and MouseEvent at some point in the past, and now it's causing ...
3 years, 7 months ago (2017-05-22 20:59:24 UTC) #2
Alan Knight
3 years, 7 months ago (2017-05-22 20:59:44 UTC) #3
Jacob
lgtm
3 years, 7 months ago (2017-05-22 21:07:05 UTC) #4
Alan Knight
Committed patchset #1 (id:1) manually as fbbb97467030db2f0996e19f3c5bc133851dee31 (presubmit successful).
3 years, 7 months ago (2017-05-22 21:10:13 UTC) #6
Alan Knight
3 years, 7 months ago (2017-05-25 18:12:12 UTC) #7
Message was sent while issue was closed.
Reverting, see https://codereview.chromium.org/2907563003/

Powered by Google App Engine
This is Rietveld 408576698