Implement PermissionServiceImpl::RequestPermission in terms of RequestPermissions

Implement PermissionServiceImpl::RequestPermission in terms of RequestPermissions

This removes duplicate code from PermissionServiceImpl.
RequestPermissions and RequestPermission used to duplicate most of their
code. Instead RequestPermission is now implemented on top of the more
general RequestPermissions function, but with only a single item in the
request vector. This is in preparation for adding feature policy checks
to these functions, which would otherwise add more duplicated code.

This also fixes a small bug in ShellPermissionManager which was tickled by this change.

BUG=689802
Review-Url: https://codereview.chromium.org/2898653004
Cr-Commit-Position: refs/heads/master@{#475282}
Committed: https://chromium.googlesource.com/chromium/src/+/d93dbb23431e74ccc31aba4183fc2aef78a6553c

[raymes, 2017-05-23 05:06:27]

raymes@chromium.org changed reviewers:
+ mlamouri@chromium.org

[raymes, 2017-05-23 05:12:45]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 05:12:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 05:39:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 05:39:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[raymes, 2017-05-23 05:47:31]

Description was changed from

==========
Implement PermissionServiceImpl::RequestPermission in terms of
RequestPermissions

This removes duplicate code from PermissionServiceImpl.
RequestPermissions and RequestPermission used to duplicate most of their
code. Instead RequestPermission is now implemented on top of the more
general RequestPermissions function, but with only a single item in the
request vector. This is in preparation for adding feature policy checks
to these functions, which would otherwise add more duplicated code.

BUG=689802
==========

to

==========
Implement PermissionServiceImpl::RequestPermission in terms of
RequestPermissions

This removes duplicate code from PermissionServiceImpl.
RequestPermissions and RequestPermission used to duplicate most of their
code. Instead RequestPermission is now implemented on top of the more
general RequestPermissions function, but with only a single item in the
request vector. This is in preparation for adding feature policy checks
to these functions, which would otherwise add more duplicated code.

This also fixes a small bug in ShellPermissionManager.

BUG=689802
==========

[raymes, 2017-05-23 05:47:45]

Description was changed from

==========
Implement PermissionServiceImpl::RequestPermission in terms of
RequestPermissions

This removes duplicate code from PermissionServiceImpl.
RequestPermissions and RequestPermission used to duplicate most of their
code. Instead RequestPermission is now implemented on top of the more
general RequestPermissions function, but with only a single item in the
request vector. This is in preparation for adding feature policy checks
to these functions, which would otherwise add more duplicated code.

This also fixes a small bug in ShellPermissionManager.

BUG=689802
==========

to

==========
Implement PermissionServiceImpl::RequestPermission in terms of
RequestPermissions

This removes duplicate code from PermissionServiceImpl.
RequestPermissions and RequestPermission used to duplicate most of their
code. Instead RequestPermission is now implemented on top of the more
general RequestPermissions function, but with only a single item in the
request vector. This is in preparation for adding feature policy checks
to these functions, which would otherwise add more duplicated code.

This also fixes a small bug in ShellPermissionManager which was tickled by this
change.

BUG=689802
==========

[raymes, 2017-05-23 05:47:51]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 05:48:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 06:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 06:44:59]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-05-24 01:09:41]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 01:11:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 04:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 04:20:08]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-05-24 22:59:58]

ping :)

[mlamouri (slow - plz ping), 2017-05-26 14:54:46]

lgtm

[raymes, 2017-05-29 00:18:42]

raymes@chromium.org changed reviewers:
+ kinuko@chromium.org

[raymes, 2017-05-29 00:18:43]

+kinuko for the very small bugfix in 
content/shell/browser/shell_permission_manager.cc

[raymes, 2017-05-29 00:18:56]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 00:19:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 01:44:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 01:44:01]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-05-29 03:51:20]

lgtm

[raymes, 2017-05-29 03:52:37]

The CQ bit was checked by raymes@chromium.org

[raymes, 2017-05-29 03:52:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2898653004/#ps80001
(title: "Implement PermissionServiceImpl::RequestPermission in terms of
RequestPermissions")

[commit-bot: I haz the power, 2017-05-29 03:52:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 03:56:56]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496029957445750,
"parent_rev": "fc164e82a40e8ac5bd0d80bf70ef38aa835ca438", "commit_rev":
"d93dbb23431e74ccc31aba4183fc2aef78a6553c"}

[commit-bot: I haz the power, 2017-05-29 03:57:09]

Description was changed from

==========
Implement PermissionServiceImpl::RequestPermission in terms of
RequestPermissions

This removes duplicate code from PermissionServiceImpl.
RequestPermissions and RequestPermission used to duplicate most of their
code. Instead RequestPermission is now implemented on top of the more
general RequestPermissions function, but with only a single item in the
request vector. This is in preparation for adding feature policy checks
to these functions, which would otherwise add more duplicated code.

This also fixes a small bug in ShellPermissionManager which was tickled by this
change.

BUG=689802
==========

to

==========
Implement PermissionServiceImpl::RequestPermission in terms of
RequestPermissions

This removes duplicate code from PermissionServiceImpl.
RequestPermissions and RequestPermission used to duplicate most of their
code. Instead RequestPermission is now implemented on top of the more
general RequestPermissions function, but with only a single item in the
request vector. This is in preparation for adding feature policy checks
to these functions, which would otherwise add more duplicated code.

This also fixes a small bug in ShellPermissionManager which was tickled by this
change.

BUG=689802

Review-Url: https://codereview.chromium.org/2898653004
Cr-Commit-Position: refs/heads/master@{#475282}
Committed:
https://chromium.googlesource.com/chromium/src/+/d93dbb23431e74ccc31aba4183fc...
==========

[commit-bot: I haz the power, 2017-05-29 03:57:10]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d93dbb23431e74ccc31aba4183fc...