Layout the translate bubble after changing child view visibility.

Layout the translate bubble after changing child view visibility.

BoxLayout only manipulates visible subviews, so making a subview newly
visible may require a layout.

A SizeToContents() call can also trigger Layout() but only if the size
of the Widget actually changes. r466211 removed some unnecessary insets
such that this was no longer likely for a particular translate bubble
UI transition.

BUG=721213, 658854
TEST=(see bug) On Windows, set flags:
 - chrome://flags/#translate-2016q2-ui Disabled.
 - chrome://flags/#secondary-ui-md Enabled.
Go to a page that needs translating and translate it. Ensure the
"Show original" button is positioned in the bottom-right and clickable.

Review-Url: https://codereview.chromium.org/2898633004
Cr-Commit-Position: refs/heads/master@{#474511}
Committed: https://chromium.googlesource.com/chromium/src/+/bb91c5093e7b44830872d79d95d4c391c82776b8

[tapted, 2017-05-23 05:21:12]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 05:21:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 06:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 06:05:50]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-05-23 06:34:12]

tapted@chromium.org changed reviewers:
+ groby@chromium.org

[tapted, 2017-05-23 06:34:13]

Hiya groby, please take a look

[tapted, 2017-05-23 06:37:53]

Description was changed from

==========
Layout the translate bubble after changing child view visibility.

BoxLayout only manipulates visible subviews, so making a subview newly
visible may require a layout.

A SizeToContents() call can also trigger Layout() but only if the size
of the Widget actually changes. r466211 removed some unnecessary insets
such that this was no longer likely for a particular translate bubble
UI transition.

BUG=721213
TEST=(see bug) On Windows, set flags:
 - chrome://flags/#translate-2016q2-ui Disabled.
 - chrome://flags/#secondary-ui-md Enabled.
Go to a page that needs translating and translate it. Ensure the
"Show original" button is positioned in the bottom-right and clickable.
==========

to

==========
Layout the translate bubble after changing child view visibility.

BoxLayout only manipulates visible subviews, so making a subview newly
visible may require a layout.

A SizeToContents() call can also trigger Layout() but only if the size
of the Widget actually changes. r466211 removed some unnecessary insets
such that this was no longer likely for a particular translate bubble
UI transition.

BUG=721213, 658854
TEST=(see bug) On Windows, set flags:
 - chrome://flags/#translate-2016q2-ui Disabled.
 - chrome://flags/#secondary-ui-md Enabled.
Go to a page that needs translating and translate it. Ensure the
"Show original" button is positioned in the bottom-right and clickable.
==========

[tapted, 2017-05-24 22:59:20]

groby: ping?

[groby-ooo-7-16, 2017-05-25 00:34:27]

The CQ bit was checked by groby@chromium.org

[groby-ooo-7-16, 2017-05-25 00:34:27]

lgtm

[commit-bot: I haz the power, 2017-05-25 00:35:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 01:31:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495672467346360, "parent_rev":
"e66a502427e1744331aef5edf65c417dc244ae0c", "commit_rev":
"bb91c5093e7b44830872d79d95d4c391c82776b8"}

[commit-bot: I haz the power, 2017-05-25 01:31:59]

Description was changed from

==========
Layout the translate bubble after changing child view visibility.

BoxLayout only manipulates visible subviews, so making a subview newly
visible may require a layout.

A SizeToContents() call can also trigger Layout() but only if the size
of the Widget actually changes. r466211 removed some unnecessary insets
such that this was no longer likely for a particular translate bubble
UI transition.

BUG=721213, 658854
TEST=(see bug) On Windows, set flags:
 - chrome://flags/#translate-2016q2-ui Disabled.
 - chrome://flags/#secondary-ui-md Enabled.
Go to a page that needs translating and translate it. Ensure the
"Show original" button is positioned in the bottom-right and clickable.
==========

to

==========
Layout the translate bubble after changing child view visibility.

BoxLayout only manipulates visible subviews, so making a subview newly
visible may require a layout.

A SizeToContents() call can also trigger Layout() but only if the size
of the Widget actually changes. r466211 removed some unnecessary insets
such that this was no longer likely for a particular translate bubble
UI transition.

BUG=721213, 658854
TEST=(see bug) On Windows, set flags:
 - chrome://flags/#translate-2016q2-ui Disabled.
 - chrome://flags/#secondary-ui-md Enabled.
Go to a page that needs translating and translate it. Ensure the
"Show original" button is positioned in the bottom-right and clickable.

Review-Url: https://codereview.chromium.org/2898633004
Cr-Commit-Position: refs/heads/master@{#474511}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb91c5093e7b44830872d79d95d4...
==========

[commit-bot: I haz the power, 2017-05-25 01:32:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb91c5093e7b44830872d79d95d4...