Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2898543002: media_controls: Add UI for showing a promo bubble on a control button. (Closed)

Created:
3 years, 7 months ago by Khushal
Modified:
3 years, 6 months ago
CC:
chromium-reviews, nektar+watch_chromium.org, fs, eric.carlson_apple.com, dougt+watch_chromium.org, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, Srirama, rwlbuis, aboxhall, aboxhall+watch_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, jam, dglazkov+blink, je_julie, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org, nessy, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, dmazzoni, darktears, haraken, mlamouri+watch-blink_chromium.org, gasubic, nektarios, dtseng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

media_controls: Add UI for showing a promo bubble on a control button. The change adds the UI to be able to show a floating bubble pointing to a media control element. This only adds the DOM for this UI, it is not appended to the heirarchy yet. BUG=715185

Patch Set 1 #

Patch Set 2 : .. #

Patch Set 3 : .. #

Total comments: 3

Patch Set 4 : .. #

Patch Set 5 : make animation work #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -11 lines) Patch
M content/app/strings/content_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/mediaControls.css View 1 2 3 3 chunks +84 lines, -3 lines 2 comments Download
M third_party/WebKit/Source/core/css/mediaControlsAndroid.css View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp View 1 5 chunks +21 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/media_controls/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp View 1 2 6 chunks +22 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlButtonPromoElements.h View 1 2 3 4 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlButtonPromoElements.cpp View 1 2 3 4 1 chunk +74 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebLocalizedString.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Khushal
Does this look reasonable? https://codereview.chromium.org/2898543002/diff/40001/third_party/WebKit/Source/core/css/mediaControls.css File third_party/WebKit/Source/core/css/mediaControls.css (right): https://codereview.chromium.org/2898543002/diff/40001/third_party/WebKit/Source/core/css/mediaControls.css#newcode639 third_party/WebKit/Source/core/css/mediaControls.css:639: @keyframes -internal-media-controls-promo-throbbing { For some ...
3 years, 7 months ago (2017-05-20 01:48:08 UTC) #4
Khushal
https://codereview.chromium.org/2898543002/diff/40001/third_party/WebKit/Source/core/css/mediaControls.css File third_party/WebKit/Source/core/css/mediaControls.css (right): https://codereview.chromium.org/2898543002/diff/40001/third_party/WebKit/Source/core/css/mediaControls.css#newcode639 third_party/WebKit/Source/core/css/mediaControls.css:639: @keyframes -internal-media-controls-promo-throbbing { On 2017/05/20 01:48:08, Khushal wrote: > ...
3 years, 7 months ago (2017-05-22 18:19:32 UTC) #5
Khushal
Testing this change on a few EM pages, the promo ends up being clipped with ...
3 years, 7 months ago (2017-05-23 21:28:23 UTC) #7
kochi
3 years, 7 months ago (2017-05-25 05:26:40 UTC) #9
https://codereview.chromium.org/2898543002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/mediaControls.css (right):

https://codereview.chromium.org/2898543002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/mediaControls.css:643: }
As it's now in per-shadow <style>, this definition is
not necessary.

https://codereview.chromium.org/2898543002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/mediaControls.css:655: animation:
-internal-media-controls-promo-throbbing 2s infinite;
Ditto - maybe leave non-animation lines here, and only add
animation in the per-shadow <style>? (I suppose it would work)

Powered by Google App Engine
This is Rietveld 408576698