Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2898523002: Remove the usage of BrowserThread::FILE in web_ui_user_script_loader.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 20 hours ago by Patrick Monette
Modified:
4 days, 17 hours ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the usage of BrowserThread::FILE in web_ui_user_script_loader.cc The usage of BrowserThread::FILE is deprecated in favor of the post_task.h API. BUG=689520 Review-Url: https://codereview.chromium.org/2898523002 Cr-Commit-Position: refs/heads/master@{#473387} Committed: https://chromium.googlesource.com/chromium/src/+/40c99bcdd1a0c0bcd3dbcfd2c49733621eb40614

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
Patrick Monette
PTAL
4 days, 19 hours ago (2017-05-19 22:23:36 UTC) #6
Devlin (catching up)
lgtm
4 days, 18 hours ago (2017-05-19 22:52:46 UTC) #7
Patrick Monette
Thanks!
4 days, 18 hours ago (2017-05-19 23:38:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898523002/1
4 days, 18 hours ago (2017-05-19 23:39:25 UTC) #10
commit-bot: I haz the power
4 days, 17 hours ago (2017-05-19 23:59:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40c99bcdd1a0c0bcd3dbcfd2c497...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06