Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2898523002: Remove the usage of BrowserThread::FILE in web_ui_user_script_loader.cc (Closed)

Created:
3 years, 7 months ago by Patrick Monette
Modified:
3 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the usage of BrowserThread::FILE in web_ui_user_script_loader.cc The usage of BrowserThread::FILE is deprecated in favor of the post_task.h API. BUG=689520 Review-Url: https://codereview.chromium.org/2898523002 Cr-Commit-Position: refs/heads/master@{#473387} Committed: https://chromium.googlesource.com/chromium/src/+/40c99bcdd1a0c0bcd3dbcfd2c49733621eb40614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M extensions/browser/extension_user_script_loader.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M extensions/browser/user_script_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/web_ui_user_script_loader.cc View 3 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Patrick Monette
PTAL
3 years, 7 months ago (2017-05-19 22:23:36 UTC) #6
Devlin
lgtm
3 years, 7 months ago (2017-05-19 22:52:46 UTC) #7
Patrick Monette
Thanks!
3 years, 7 months ago (2017-05-19 23:38:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898523002/1
3 years, 7 months ago (2017-05-19 23:39:25 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 23:59:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40c99bcdd1a0c0bcd3dbcfd2c497...

Powered by Google App Engine
This is Rietveld 408576698