Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2898513002: [EasyUnlock] Observe proximity changes and clean up TX power strategy. (Closed)

Created:
3 years, 7 months ago by Tim Song
Modified:
3 years, 7 months ago
Reviewers:
sacomoto
CC:
chromium-reviews, extensions-reviews_chromium.org, jlklein+watch-tether_chromium.org, lesliewatkins+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, chromium-apps-reviews_chromium.org, srahim+watch_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[EasyUnlock] Observe proximity changes and clean up TX power strategy. With BLE, we only check the RSSI, so we can now remove all references to the TX power proximity strategy. Review-Url: https://codereview.chromium.org/2898513002 Cr-Commit-Position: refs/heads/master@{#473768} Committed: https://chromium.googlesource.com/chromium/src/+/a252bab61a3811269fdca54ca84083856a7e2934

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix test #

Patch Set 3 : fix_unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -46 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/easy_unlock_metrics.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.cc View 1 2 3 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/proximity_auth/proximity_monitor_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/screenlock_state.h View 1 chunk +1 line, -6 lines 0 comments Download
M components/proximity_auth/unlock_manager_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M components/proximity_auth/unlock_manager_impl.cc View 12 chunks +27 lines, -13 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
Tim Song
3 years, 7 months ago (2017-05-19 20:53:10 UTC) #2
sacomoto
LGTM. https://codereview.chromium.org/2898513002/diff/1/components/proximity_auth/proximity_monitor_impl.cc File components/proximity_auth/proximity_monitor_impl.cc (right): https://codereview.chromium.org/2898513002/diff/1/components/proximity_auth/proximity_monitor_impl.cc#newcode29 components/proximity_auth/proximity_monitor_impl.cc:29: // proximity. Please add to the comment the ...
3 years, 7 months ago (2017-05-22 07:30:30 UTC) #3
Tim Song
https://codereview.chromium.org/2898513002/diff/1/components/proximity_auth/proximity_monitor_impl.cc File components/proximity_auth/proximity_monitor_impl.cc (right): https://codereview.chromium.org/2898513002/diff/1/components/proximity_auth/proximity_monitor_impl.cc#newcode29 components/proximity_auth/proximity_monitor_impl.cc:29: // proximity. On 2017/05/22 07:30:29, sacomoto wrote: > Please ...
3 years, 7 months ago (2017-05-22 17:51:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898513002/1
3 years, 7 months ago (2017-05-22 17:51:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/390052)
3 years, 7 months ago (2017-05-22 18:17:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898513002/20001
3 years, 7 months ago (2017-05-22 19:57:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/79909)
3 years, 7 months ago (2017-05-22 20:36:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898513002/40001
3 years, 7 months ago (2017-05-22 22:26:33 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/433519)
3 years, 7 months ago (2017-05-22 23:41:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898513002/40001
3 years, 7 months ago (2017-05-23 00:10:38 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 00:55:37 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a252bab61a3811269fdca54ca840...

Powered by Google App Engine
This is Rietveld 408576698