Implement GetBrowsingDataRemoverDelegate() for BrowserContext subclasses

Implement GetBrowsingDataRemoverDelegate() for BrowserContext subclasses

As a part of the refactoring to move BrowsingDataRemover to content/,
the GetBrowsingDataRemoverDelegate() method has been defined in
BrowserContext with a default "return nulltpr" implementation, overriden
by ProfileImpl to return ChromeBrowsingDataRemoverDelegate.

However, similar methods in BrowserContext do not have a default
implementation, but are declared as pure virtual. We change this method
to be pure virtual as well.

ProfileImpl and OffTheRecordProfile use
ChromeBrowsingDataRemoverDelegate. So does TestingProfile, which
means that the helper TestingProfileWithDelegate can now be removed
from ChromeBrowsingDataRemoverDelegateTest. All other subclasses
return nullptr.

BUG=668114
Review-Url: https://codereview.chromium.org/2898443002
Cr-Commit-Position: refs/heads/master@{#475885}
Committed: https://chromium.googlesource.com/chromium/src/+/86b6bc73feadfa473080ed1e7ec8aebd38a1cc68

[msramek, 2017-05-19 13:24:21]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 13:24:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 13:41:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 13:41:08]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[msramek, 2017-05-19 14:12:54]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 14:13:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 14:42:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 14:42:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msramek, 2017-05-19 16:29:50]

Description was changed from

==========
Implement GetBrowsingDataRemoverDelegate() for BrowserContext subclasses

As a part of the refactoring to move BrowsingDataRemover to content/,
the GetBrowsingDataRemoverDelegate() method has been defined in
BrowserContext with a default "return nulltpr" implementation, overriden
by ProfileImpl to return ChromeBrowsingDataRemoverDelegate.

However, similar methods in BrowserContext do not have a default
implementation, but are declared as pure virtual. We change this method
to be pure virtual as well.

All BrowserContext subclasses in chrome/ now use
ChromeBrowsingDataRemoverDelegate, including TestingProfile, which
means that the helper TestingProfileWithDelegate can now be removed
from ChromeBrowsingDataRemoverDelegateTest. All other subclasses
return nullptr.

BUG=668114
==========

to

==========
Implement GetBrowsingDataRemoverDelegate() for BrowserContext subclasses

As a part of the refactoring to move BrowsingDataRemover to content/,
the GetBrowsingDataRemoverDelegate() method has been defined in
BrowserContext with a default "return nulltpr" implementation, overriden
by ProfileImpl to return ChromeBrowsingDataRemoverDelegate.

However, similar methods in BrowserContext do not have a default
implementation, but are declared as pure virtual. We change this method
to be pure virtual as well.

ProfileImpl and OffTheRecordProfile use
ChromeBrowsingDataRemoverDelegate. So does TestingProfile, which
means that the helper TestingProfileWithDelegate can now be removed
from ChromeBrowsingDataRemoverDelegateTest. All other subclasses
return nullptr.

BUG=668114
==========

[msramek, 2017-05-19 16:30:02]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 16:30:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-05-19 16:51:10]

msramek@chromium.org changed reviewers:
+ alokp@chromium.org, boliu@chromium.org, jochen@chromium.org,
skyostil@chromium.org

[msramek, 2017-05-19 16:51:10]

Hi folks,

Please have a look! This is a trivial change, but spans a lot of files.

jochen@: chrome/, content/
boliu@: android_webview/
alokp@: chromecast/
skyostil@: headless/

Thanks!
Martin

[alokp, 2017-05-19 16:57:22]

chromecast/ lgtm

[boliu, 2017-05-19 17:33:32]

android_webview lgtm

[commit-bot: I haz the power, 2017-05-19 18:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 18:34:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[msramek, 2017-05-19 18:44:18]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 18:45:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 21:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 21:19:42]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-05-22 11:47:39]

lgtm

[msramek, 2017-05-24 14:00:51]

Sami - friendly ping :) This is a very small change.

[msramek, 2017-05-26 13:45:22]

On 2017/05/24 14:00:51, msramek wrote:
> Sami - friendly ping :) This is a very small change.

Ping?

[Sami, 2017-05-31 10:25:24]

Apologies for the delay, I'm not sure this slipped by me. lgtm.

[msramek, 2017-05-31 10:31:20]

Thanks!

[msramek, 2017-05-31 10:31:28]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2017-05-31 10:31:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 12:21:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496226688188200,
"parent_rev": "09c379de358b916213f0591a5214b60e76dfb224", "commit_rev":
"86b6bc73feadfa473080ed1e7ec8aebd38a1cc68"}

[commit-bot: I haz the power, 2017-05-31 12:21:32]

Description was changed from

==========
Implement GetBrowsingDataRemoverDelegate() for BrowserContext subclasses

As a part of the refactoring to move BrowsingDataRemover to content/,
the GetBrowsingDataRemoverDelegate() method has been defined in
BrowserContext with a default "return nulltpr" implementation, overriden
by ProfileImpl to return ChromeBrowsingDataRemoverDelegate.

However, similar methods in BrowserContext do not have a default
implementation, but are declared as pure virtual. We change this method
to be pure virtual as well.

ProfileImpl and OffTheRecordProfile use
ChromeBrowsingDataRemoverDelegate. So does TestingProfile, which
means that the helper TestingProfileWithDelegate can now be removed
from ChromeBrowsingDataRemoverDelegateTest. All other subclasses
return nullptr.

BUG=668114
==========

to

==========
Implement GetBrowsingDataRemoverDelegate() for BrowserContext subclasses

As a part of the refactoring to move BrowsingDataRemover to content/,
the GetBrowsingDataRemoverDelegate() method has been defined in
BrowserContext with a default "return nulltpr" implementation, overriden
by ProfileImpl to return ChromeBrowsingDataRemoverDelegate.

However, similar methods in BrowserContext do not have a default
implementation, but are declared as pure virtual. We change this method
to be pure virtual as well.

ProfileImpl and OffTheRecordProfile use
ChromeBrowsingDataRemoverDelegate. So does TestingProfile, which
means that the helper TestingProfileWithDelegate can now be removed
from ChromeBrowsingDataRemoverDelegateTest. All other subclasses
return nullptr.

BUG=668114

Review-Url: https://codereview.chromium.org/2898443002
Cr-Commit-Position: refs/heads/master@{#475885}
Committed:
https://chromium.googlesource.com/chromium/src/+/86b6bc73feadfa473080ed1e7ec8...
==========

[commit-bot: I haz the power, 2017-05-31 12:21:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/86b6bc73feadfa473080ed1e7ec8...