Source/bindings/scripts/v8_interface.py - Issue 289843006: Avoid extra arity and type check on distinguishing argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 289843006: Avoid extra arity and type check on distinguishing argument (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: additional test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 9ea47ae0e37c532ba3e2aab293cab46244aaf2ef..f194428dcf5309339f495aa9d1d389db3bb8c958 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -614,6 +614,9 @@ def resolution_tests_methods(effective_overloads):

# 6. If there is more than one entry in S, then set d to be the

# distinguishing argument index for the entries of S.

index = distinguishing_argument_index(effective_overloads)

+ for method in methods:

+ method['distinguishing_argument_index'] = index

# (7-9 are for handling |undefined| values for optional arguments before

# the distinguishing argument (as “missing”), so you can specify only some

# optional arguments. We don’t support this, so we skip these steps.)

« no previous file with comments | « no previous file | Source/bindings/templates/methods.cpp » ('j') | Source/bindings/tests/idls/TestObject.idl » ('J')