Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: Source/bindings/tests/idls/TestObject.idl

Issue 289843006: Avoid extra arity and type check on distinguishing argument (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: additional test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/idls/TestObject.idl
diff --git a/Source/bindings/tests/idls/TestObject.idl b/Source/bindings/tests/idls/TestObject.idl
index 3ec4e3c54b67bf70b8b55c39fa265ec244c12900..56405bfe4e7cdf6e7bedd592262cb04342f9028e 100644
--- a/Source/bindings/tests/idls/TestObject.idl
+++ b/Source/bindings/tests/idls/TestObject.idl
@@ -410,6 +410,11 @@ interface TestObject {
void overloadedMethodK(TestInterfaceEmpty testInterfaceEmptyArg);
void overloadedMethodL(DOMString stringArg);
void overloadedMethodL(double doubleArg);
+ [TypeChecking=Interface] void overloadedMethodM(TestInterface testInterfaceArg1, TestInterface testInterfaceArg2);
+ [TypeChecking=Interface] void overloadedMethodM(TestInterface testInterfaceArg, TestInterfaceEmpty testInterfaceEmptyArg);
+ [TypeChecking=Interface] void overloadedMethodN(double a, TestInterface b);
Nils Barth (inactive) 2014/05/16 02:15:46 You don't need the double here do you? ...and this
Jens Widell 2014/05/16 05:59:17 Don't think I do, no. Unclear why I thought I did.
Nils Barth (inactive) 2014/05/16 06:05:31 I don't think that's necessary, but thanks for ask
+ [TypeChecking=Interface] void overloadedMethodN(double a, TestInterfaceEmpty b, optional TestInterface c);
+ [TypeChecking=Interface] void overloadedMethodN(double a, TestInterfaceEmpty b, TestInterfaceEmpty c);
[PerWorldBindings] void overloadedPerWorldBindingsMethod();
« no previous file with comments | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698