Remove references to GClientKeywords.FromImpl from roll scripts

Remove references to GClientKeywords.FromImpl from roll scripts

This class was removed because it was no longer used but some roll
scripts were still referencing it. Also removes a dummy FromImpl in
PRESUBMIT.py as it shouldn't be needed anymore.

TBR=dpranke@chromium.org

BUG=661382
Review-Url: https://codereview.chromium.org/2898403003
Cr-Commit-Position: refs/heads/master@{#474329}
Committed: https://chromium.googlesource.com/chromium/src/+/c3a2fa143c3b2b867d74738b0978faf8818388a1

[Corentin Wallez, 2017-05-24 14:47:18]

cwallez@chromium.org changed reviewers:
+ dpranke@chromium.org, phajdan.jr@chromium.org

[Corentin Wallez, 2017-05-24 14:47:18]

Pawel, PTAL this fixes the roll_angle scripts. dpranke@ TBR for all the
tools/roll_*

[Corentin Wallez, 2017-05-24 14:47:29]

Description was changed from

==========
Remove references to GClientKeywords.FromImpl from roll scripts

This class was removed because it was no longer used but some roll
scripts were still referencing it. Also removes a dummy FromImpl in
PRESUBMIT.py as it shouldn't be needed anymore.

BUG=661382
==========

to

==========
Remove references to GClientKeywords.FromImpl from roll scripts

This class was removed because it was no longer used but some roll
scripts were still referencing it. Also removes a dummy FromImpl in
PRESUBMIT.py as it shouldn't be needed anymore.

TBR=dpranke@chromium.org

BUG=661382
==========

[Dirk Pranke, 2017-05-24 16:38:47]

lgtm

https://codereview.chromium.org/2898403003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (left):

https://codereview.chromium.org/2898403003/diff/1/PRESUBMIT.py#oldcode1147
PRESUBMIT.py:1147: pass  # NOP function so "File" doesn't fail.
Nit: you can remove FileImpl(), also.

[Corentin Wallez, 2017-05-24 16:43:19]

On 2017/05/24 at 16:38:47, dpranke wrote:
> lgtm
> 
> https://codereview.chromium.org/2898403003/diff/1/PRESUBMIT.py
> File PRESUBMIT.py (left):
> 
> https://codereview.chromium.org/2898403003/diff/1/PRESUBMIT.py#oldcode1147
> PRESUBMIT.py:1147: pass  # NOP function so "File" doesn't fail.
> Nit: you can remove FileImpl(), also.

Done, thanks for the review

[Corentin Wallez, 2017-05-24 16:43:21]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2017-05-24 16:43:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2898403003/#ps20001
(title: "Remove FileImpl too")

[commit-bot: I haz the power, 2017-05-24 16:43:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 16:59:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495644201496310,
"parent_rev": "e2de3c59dce2f77b927fc411b62f1df6e8739504", "commit_rev":
"c3a2fa143c3b2b867d74738b0978faf8818388a1"}

[commit-bot: I haz the power, 2017-05-24 16:59:35]

Description was changed from

==========
Remove references to GClientKeywords.FromImpl from roll scripts

This class was removed because it was no longer used but some roll
scripts were still referencing it. Also removes a dummy FromImpl in
PRESUBMIT.py as it shouldn't be needed anymore.

TBR=dpranke@chromium.org

BUG=661382
==========

to

==========
Remove references to GClientKeywords.FromImpl from roll scripts

This class was removed because it was no longer used but some roll
scripts were still referencing it. Also removes a dummy FromImpl in
PRESUBMIT.py as it shouldn't be needed anymore.

TBR=dpranke@chromium.org

BUG=661382

Review-Url: https://codereview.chromium.org/2898403003
Cr-Commit-Position: refs/heads/master@{#474329}
Committed:
https://chromium.googlesource.com/chromium/src/+/c3a2fa143c3b2b867d74738b0978...
==========

[commit-bot: I haz the power, 2017-05-24 16:59:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c3a2fa143c3b2b867d74738b0978...