Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: chrome/browser/offline_pages/DEPS

Issue 2898393002: Split Android-specific dependency from BackgroundLoaderOffliner. Create a subfolder of c/b/offline_… (Closed)
Patch Set: more build fixes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/offline_pages/DEPS
diff --git a/chrome/browser/offline_pages/DEPS b/chrome/browser/offline_pages/DEPS
index e12d27aeda12b72651a5ed6d16124be14b0566d6..c721a5988e8bf7e23f39d2a984aa61140e5f3ca7 100644
--- a/chrome/browser/offline_pages/DEPS
+++ b/chrome/browser/offline_pages/DEPS
@@ -2,8 +2,8 @@ include_rules = [
# This folder should not depend on specific platform implementations.
# This restriction helps in moving files here since historically offline_pages
# were android-only and thus accumulated many unnecessary dependencies on
- # Android.
- # TODO(dimich): replace these with "-" version soon.
- "!base/android",
+ # Android. OS-specific subfolders should have their own DEPS enabling specific
+ # dependencies.
+ "-base/android",
"!chrome/browser/android",
]

Powered by Google App Engine
This is Rietveld 408576698