Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: chrome/browser/android/offline_pages/request_coordinator_factory.cc

Issue 2898393002: Split Android-specific dependency from BackgroundLoaderOffliner. Create a subfolder of c/b/offline_… (Closed)
Patch Set: more build fixes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/request_coordinator_factory.cc
diff --git a/chrome/browser/android/offline_pages/request_coordinator_factory.cc b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
index 53bd4ca5a7be67d6d3c0c2eb5e88e431358f44dd..e4c82ae884d9455073502beddf30cbbcbada1e27 100644
--- a/chrome/browser/android/offline_pages/request_coordinator_factory.cc
+++ b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/android/offline_pages/prerendering_offliner.h"
#include "chrome/browser/net/nqe/ui_network_quality_estimator_service.h"
#include "chrome/browser/net/nqe/ui_network_quality_estimator_service_factory.h"
+#include "chrome/browser/offline_pages/android/load_termination_listener_impl.h"
dewittj 2017/05/24 23:24:40 I assume that this file will eventually want to mo
Dmitry Titov 2017/05/25 23:24:12 My thought was that factories, as main dependency
#include "chrome/browser/offline_pages/background_loader_offliner.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_constants.h"
@@ -62,7 +63,10 @@ KeyedService* RequestCoordinatorFactory::BuildServiceInstanceFor(
// Determines which offliner to use based on flag.
if (ShouldUseNewBackgroundLoader()) {
- offliner.reset(new BackgroundLoaderOffliner(context, policy.get(), model));
+ std::unique_ptr<LoadTerminationListenerImpl> load_termination_listener =
+ base::MakeUnique<LoadTerminationListenerImpl>();
+ offliner.reset(new BackgroundLoaderOffliner(
+ context, policy.get(), model, std::move(load_termination_listener)));
} else {
offliner.reset(new PrerenderingOffliner(context, policy.get(), model));
}

Powered by Google App Engine
This is Rietveld 408576698