chrome/browser/extensions/api/feedback_private/feedback_private_api.cc - Issue 2898383002: [Extensions] Make Event::restrict_to_browser_context const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2898383002: [Extensions] Make Event::restrict_to_browser_context const. (Closed)

Patch Set: sync @tott Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/browser/extensions/api/history/history_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

index b13cf765fee1e86d05d99ee2bb3f87d5ef7e24a0..06952f2e5069bbcae4a4c8970e268e9ec8e17e8c 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

@@ -147,10 +147,10 @@ void FeedbackPrivateAPI::RequestFeedbackForFlow(

std::unique_ptr<base::ListValue> args =

feedback_private::OnFeedbackRequested::Create(info);

- std::unique_ptr<Event> event(new Event(

+ auto event = base::MakeUnique<Event>(

events::FEEDBACK_PRIVATE_ON_FEEDBACK_REQUESTED,

- feedback_private::OnFeedbackRequested::kEventName, std::move(args)));

- event->restrict_to_browser_context = browser_context_;

+ feedback_private::OnFeedbackRequested::kEventName, std::move(args),

+ browser_context_);

EventRouter::Get(browser_context_)

->DispatchEventToExtension(extension_misc::kFeedbackExtensionId,