chrome/browser/extensions/api/extension_action/extension_action_api.cc - Issue 2898383002: [Extensions] Make Event::restrict_to_browser_context const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 2898383002: [Extensions] Make Event::restrict_to_browser_context const. (Closed)

Patch Set: sync @tott Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/extensions/api/feedback_private/feedback_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

index 326d808766448c611ad7e4fd9d25c8d22f9499da..577edb340747165cd7e6d3522d703488636c689d 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

@@ -274,9 +274,8 @@ void ExtensionActionAPI::DispatchEventToExtension(

if (!EventRouter::Get(context))

return;

- std::unique_ptr<Event> event(

- new Event(histogram_value, event_name, std::move(event_args)));

- event->restrict_to_browser_context = context;

+ auto event = base::MakeUnique<Event>(histogram_value, event_name,

+ std::move(event_args), context);

event->user_gesture = EventRouter::USER_GESTURE_ENABLED;

EventRouter::Get(context)

->DispatchEventToExtension(extension_id, std::move(event));