Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2898373005: Cache result of mVrDaydreamApi.isDaydreamCurrentViewer. (Closed)

Created:
3 years, 7 months ago by tiborg
Modified:
3 years, 7 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache result of mVrDaydreamApi.isDaydreamCurrentViewer. Review-Url: https://codereview.chromium.org/2898373005 Cr-Commit-Position: refs/heads/master@{#474531} Committed: https://chromium.googlesource.com/chromium/src/+/77c3cca04cb5a0501e2cd9c4db2b90db4fd246d4

Patch Set 1 #

Patch Set 2 : Set proper base CL #

Patch Set 3 : Rebased #

Total comments: 1

Patch Set 4 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 2 3 6 chunks +13 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
tiborg
PTAL
3 years, 7 months ago (2017-05-24 16:31:40 UTC) #3
mthiesse
lgtm https://codereview.chromium.org/2898373005/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java (right): https://codereview.chromium.org/2898373005/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java#newcode454 chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:454: mIsDaydreamCurrentViewer = null; nit: move into pauseVr(), trying ...
3 years, 7 months ago (2017-05-24 22:48:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898373005/60001
3 years, 7 months ago (2017-05-25 00:51:34 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 02:39:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/77c3cca04cb5a0501e2cd9c4db2b...

Powered by Google App Engine
This is Rietveld 408576698