Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2898363002: Generate enum/getters/setters/mappings for word-break. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for word-break. Currently, the word-break property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EWordBreak enum and use the generated CSSValueID <-> EWordBreak mappings. Diff of generated files: https://gist.github.com/0d411e2cb2db07f1d076383656211816/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2898363002 Cr-Commit-Position: refs/heads/master@{#474949} Committed: https://chromium.googlesource.com/chromium/src/+/ba14aca6388c04464822fb5ce91604b92c3d92a4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Total comments: 1

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -46 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (20 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-25 23:28:14 UTC) #12
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/2898363002/diff/40001/third_party/WebKit/Source/core/css/CSSProperties.json5 File third_party/WebKit/Source/core/css/CSSProperties.json5 (right): https://codereview.chromium.org/2898363002/diff/40001/third_party/WebKit/Source/core/css/CSSProperties.json5#newcode2706 third_party/WebKit/Source/core/css/CSSProperties.json5:2706: // Word Break Values. Matches WinIE and CSS3 ...
3 years, 7 months ago (2017-05-26 01:53:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898363002/60001
3 years, 7 months ago (2017-05-26 06:55:51 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 07:00:08 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ba14aca6388c04464822fb5ce916...

Powered by Google App Engine
This is Rietveld 408576698