Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 2898303005: Wire up certificate policies support in PathBuilder. (Closed)

Created:
3 years, 7 months ago by eroman
Modified:
3 years, 6 months ago
Reviewers:
dougsteed, mattm
CC:
chromium-reviews, net-reviews_chromium.org, cbentzel+watch_chromium.org, mfoltz+watch_chromium.org, dougsteed+watch_chromium.org, ryanchung+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Wire up certificate policies support in PathBuilder. BUG=634456, 634453, 634452 Review-Url: https://codereview.chromium.org/2898303005 Cr-Commit-Position: refs/heads/master@{#476827} Committed: https://chromium.googlesource.com/chromium/src/+/e0b219a58b5fa18ad52b6b9dbeca8d08d55fccfa

Patch Set 1 #

Patch Set 2 : rebase (now includes user_constrained_policy set, and inputs as enums) #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : remove extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -79 lines) Patch
M components/cast_certificate/cast_cert_validator.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download
M components/cast_certificate/cast_crl.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M net/cert/cert_verify_proc_builtin.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M net/cert/internal/path_builder.h View 1 3 chunks +15 lines, -0 lines 0 comments Download
M net/cert/internal/path_builder.cc View 1 3 chunks +19 lines, -10 lines 0 comments Download
M net/cert/internal/path_builder_pkits_unittest.cc View 1 2 3 chunks +25 lines, -7 lines 0 comments Download
M net/cert/internal/path_builder_unittest.cc View 1 2 3 25 chunks +116 lines, -49 lines 0 comments Download
M net/cert/internal/path_builder_verify_certificate_chain_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M net/tools/cert_verify_tool/verify_using_path_builder.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 33 (26 generated)
eroman
3 years, 7 months ago (2017-05-25 19:08:37 UTC) #4
mattm
lgtm w/nit https://codereview.chromium.org/2898303005/diff/40001/net/cert/internal/path_builder_unittest.cc File net/cert/internal/path_builder_unittest.cc (right): https://codereview.chromium.org/2898303005/diff/40001/net/cert/internal/path_builder_unittest.cc#newcode659 net/cert/internal/path_builder_unittest.cc:659: extra line
3 years, 6 months ago (2017-06-02 02:54:49 UTC) #13
eroman
https://codereview.chromium.org/2898303005/diff/40001/net/cert/internal/path_builder_unittest.cc File net/cert/internal/path_builder_unittest.cc (right): https://codereview.chromium.org/2898303005/diff/40001/net/cert/internal/path_builder_unittest.cc#newcode659 net/cert/internal/path_builder_unittest.cc:659: On 2017/06/02 02:54:49, mattm wrote: > extra line Done.
3 years, 6 months ago (2017-06-02 17:58:59 UTC) #17
eroman
+dougsteed@ for components/cast_certificate/* approval. There is no functional change for Cast; this just adds new ...
3 years, 6 months ago (2017-06-02 18:02:33 UTC) #22
dougsteed
lgtm
3 years, 6 months ago (2017-06-02 18:38:16 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898303005/60001
3 years, 6 months ago (2017-06-02 21:26:47 UTC) #29
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 22:56:24 UTC) #33
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e0b219a58b5fa18ad52b6b9dbeca...

Powered by Google App Engine
This is Rietveld 408576698