Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2898293002: gae.py: Remove support for MVMs (they are deprecated), simplify code a bit. (Closed)

Created:
3 years, 7 months ago by Vadim Sh.
Modified:
3 years, 7 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

gae.py: Remove support for MVMs (they are deprecated), simplify code a bit. This is still preparation for using 'gcloud app' for managing GAE apps instead of appcfg.py. R=maruel@chromium.org, iannucci@chromium.org BUG= Review-Url: https://codereview.chromium.org/2898293002 Committed: https://github.com/luci/luci-py/commit/24b7943a52c41780d20b322242d8102c85ec55da

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 3

Patch Set 3 : typo #

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -75 lines) Patch
M appengine/components/tool_support/gae_sdk_utils.py View 1 2 3 10 chunks +50 lines, -72 lines 0 comments Download
M appengine/components/tools/gae.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Vadim Sh.
PTAL https://codereview.chromium.org/2898293002/diff/20001/appengine/components/tool_support/gae_sdk_utils.py File appengine/components/tool_support/gae_sdk_utils.py (right): https://codereview.chromium.org/2898293002/diff/20001/appengine/components/tool_support/gae_sdk_utils.py#newcode285 appengine/components/tool_support/gae_sdk_utils.py:285: Doesn't close stdin, since gcloud may me asking ...
3 years, 7 months ago (2017-05-23 19:36:11 UTC) #1
iannucci
lgtm https://codereview.chromium.org/2898293002/diff/20001/appengine/components/tool_support/gae_sdk_utils.py File appengine/components/tool_support/gae_sdk_utils.py (right): https://codereview.chromium.org/2898293002/diff/20001/appengine/components/tool_support/gae_sdk_utils.py#newcode285 appengine/components/tool_support/gae_sdk_utils.py:285: Doesn't close stdin, since gcloud may me asking ...
3 years, 7 months ago (2017-05-23 19:38:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898293002/60001
3 years, 7 months ago (2017-05-23 19:43:06 UTC) #5
M-A Ruel
lgtm
3 years, 7 months ago (2017-05-23 19:46:05 UTC) #6
Vadim Sh.
https://codereview.chromium.org/2898293002/diff/20001/appengine/components/tool_support/gae_sdk_utils.py File appengine/components/tool_support/gae_sdk_utils.py (right): https://codereview.chromium.org/2898293002/diff/20001/appengine/components/tool_support/gae_sdk_utils.py#newcode285 appengine/components/tool_support/gae_sdk_utils.py:285: Doesn't close stdin, since gcloud may me asking for ...
3 years, 7 months ago (2017-05-23 19:46:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/364fa7421c9c1010)
3 years, 7 months ago (2017-05-23 19:56:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898293002/60001
3 years, 7 months ago (2017-05-23 20:29:36 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 20:31:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://github.com/luci/luci-py/commit/24b7943a52c41780d20b322242d8102c85ec55da

Powered by Google App Engine
This is Rietveld 408576698