Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2786)

Unified Diff: ash/accelerators/accelerator_table.cc

Issue 2898273002: Move Voice Interaction shortcut to accelerator_controller.cc (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/accelerators/accelerator_table.cc
diff --git a/ash/accelerators/accelerator_table.cc b/ash/accelerators/accelerator_table.cc
index f1e638b06b854889dbb5c2f676db3923a5481584..5751861b29de7c4eb85195e2d0b54c7b0f419420 100644
--- a/ash/accelerators/accelerator_table.cc
+++ b/ash/accelerators/accelerator_table.cc
@@ -161,6 +161,11 @@ const AcceleratorData kAcceleratorData[] = {
{true, ui::VKEY_MEDIA_PLAY_PAUSE, ui::EF_NONE, MEDIA_PLAY_PAUSE},
{true, ui::VKEY_MEDIA_PREV_TRACK, ui::EF_NONE, MEDIA_PREV_TRACK},
+ // Voice Interaction shortcuts.
+ {true, ui::VKEY_A, ui::EF_COMMAND_DOWN, START_VOICE_INTERACTION},
Yusuke Sato 2017/05/23 19:41:51 Shouldn't we also update chrome/browser/resources/
yueli 2017/05/23 22:59:56 Currently such accelerators should only be shown o
+ // Temporary shortcut added for UX/PM exploration.
Yusuke Sato 2017/05/23 19:41:51 Then, // TODO(ldap): Remove the accelerator. ?
yueli 2017/05/23 22:59:56 Done.
+ {true, ui::VKEY_SPACE, ui::EF_COMMAND_DOWN, START_VOICE_INTERACTION},
+
// Debugging shortcuts that need to be available to end-users in
// release builds.
{true, ui::VKEY_U, kDebugModifier, PRINT_UI_HIERARCHIES},

Powered by Google App Engine
This is Rietveld 408576698