Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2898243005: [CRD iOS] Cleanup ClientGestures (Closed)

Created:
3 years, 7 months ago by Yuwei
Modified:
3 years, 7 months ago
Reviewers:
nicholss
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Cleanup ClientGestures Since we have already added support for all gestures we previously have, we can start cleaning up the ClientGestures class now. This CL: * Removes unused and/or commented-out logic in ClientGestures. * Hides private details about the class inside the .mm file using class extension. BUG=718704 Review-Url: https://codereview.chromium.org/2898243005 Cr-Commit-Position: refs/heads/master@{#474746} Committed: https://chromium.googlesource.com/chromium/src/+/6cbaa8807189213cb4c94be2523a0b4526cda935

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase w/ ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -224 lines) Patch
M remoting/ios/client_gestures.h View 1 chunk +1 line, -56 lines 0 comments Download
M remoting/ios/client_gestures.mm View 1 12 chunks +21 lines, -168 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Yuwei
PTAL thanks! https://codereview.chromium.org/2898243005/diff/1/remoting/ios/client_gestures.h File remoting/ios/client_gestures.h (left): https://codereview.chromium.org/2898243005/diff/1/remoting/ios/client_gestures.h#oldcode59 remoting/ios/client_gestures.h:59: - (IBAction)pinchGestureTriggered:(UIPinchGestureRecognizer*)sender; I'm not sure the point ...
3 years, 7 months ago (2017-05-24 22:07:19 UTC) #2
Yuwei
Ping O_o
3 years, 7 months ago (2017-05-25 17:39:25 UTC) #7
nicholss
lgtm https://codereview.chromium.org/2898243005/diff/1/remoting/ios/client_gestures.h File remoting/ios/client_gestures.h (left): https://codereview.chromium.org/2898243005/diff/1/remoting/ios/client_gestures.h#oldcode59 remoting/ios/client_gestures.h:59: - (IBAction)pinchGestureTriggered:(UIPinchGestureRecognizer*)sender; On 2017/05/24 22:07:19, Yuwei wrote: > ...
3 years, 7 months ago (2017-05-25 17:58:12 UTC) #8
Yuwei
Thanks!
3 years, 7 months ago (2017-05-25 19:03:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898243005/20001
3 years, 7 months ago (2017-05-25 19:03:59 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 19:18:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6cbaa8807189213cb4c94be2523a...

Powered by Google App Engine
This is Rietveld 408576698