Announce to Omaha that Chrome accepts CRX₂ and CRX₃ files.

Announce to Omaha that Chrome accepts CRX₂ and CRX₃ files.

Also include the "dedup" parameter according to the protocol spec.

BUG=720092
Review-Url: https://codereview.chromium.org/2898243004
Cr-Commit-Position: refs/heads/master@{#474525}
Committed: https://chromium.googlesource.com/chromium/src/+/d4d300354ae819ac782c1938dab436fc66be4c87

[waffles, 2017-05-24 19:43:51]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 19:44:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[waffles, 2017-05-24 19:45:19]

waffles@chromium.org changed reviewers:
+ sorin@chromium.org

[waffles, 2017-05-24 19:45:20]

PTALTYVM!

[commit-bot: I haz the power, 2017-05-25 00:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 00:15:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sorin Jianu, 2017-05-25 00:18:53]

lgtm

thank you!

https://codereview.chromium.org/2898243004/diff/1/components/update_client/pr...
File components/update_client/protocol_builder.cc (right):

https://codereview.chromium.org/2898243004/diff/1/components/update_client/pr...
components/update_client/protocol_builder.cc:186: request.append("dedup=\"cr\"
acceptformat=\"crx2,crx3\" ");
Maybe use StringAppend to match the code around.

[waffles, 2017-05-25 00:25:08]

https://codereview.chromium.org/2898243004/diff/1/components/update_client/pr...
File components/update_client/protocol_builder.cc (right):

https://codereview.chromium.org/2898243004/diff/1/components/update_client/pr...
components/update_client/protocol_builder.cc:186: request.append("dedup=\"cr\"
acceptformat=\"crx2,crx3\" ");
On 2017/05/25 00:18:53, Sorin Jianu wrote:
> Maybe use StringAppend to match the code around.

Done.

[waffles, 2017-05-25 00:25:18]

The CQ bit was checked by waffles@chromium.org

[waffles, 2017-05-25 00:25:18]

The patchset sent to the CQ was uploaded after l-g-t-m from sorin@chromium.org
Link to the patchset: https://codereview.chromium.org/2898243004/#ps20001
(title: "Through #7")

[commit-bot: I haz the power, 2017-05-25 00:25:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 02:12:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495671918171770,
"parent_rev": "e8d52ddf2bd3c22f1a39c1219fceea1b070e7bf4", "commit_rev":
"d4d300354ae819ac782c1938dab436fc66be4c87"}

[commit-bot: I haz the power, 2017-05-25 02:12:41]

Description was changed from

==========
Announce to Omaha that Chrome accepts CRX₂ and CRX₃ files.

Also include the "dedup" parameter according to the protocol spec.

BUG=720092
==========

to

==========
Announce to Omaha that Chrome accepts CRX₂ and CRX₃ files.

Also include the "dedup" parameter according to the protocol spec.

BUG=720092

Review-Url: https://codereview.chromium.org/2898243004
Cr-Commit-Position: refs/heads/master@{#474525}
Committed:
https://chromium.googlesource.com/chromium/src/+/d4d300354ae819ac782c1938dab4...
==========

[commit-bot: I haz the power, 2017-05-25 02:12:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d4d300354ae819ac782c1938dab4...