PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

In previous CL[1], the PaymentAppRequest was merged with PaymentRequestEvent
due to spec change. So, we need to change the name appropriately to fit the
current implementation.

Also, this feature is still behind runtime flag (PaymentApp).

The related spec link:
  https://w3c.github.io/payment-handler/

[1] https://codereview.chromium.org/2887713002/

BUG=661608, 720027
Review-Url: https://codereview.chromium.org/2898223002
Cr-Commit-Position: refs/heads/master@{#477316}
Committed: https://chromium.googlesource.com/chromium/src/+/745f3dff09793d3a5afe793a2599eadb341d2ee0

[zino, 2017-05-25 18:08:49]

Description was changed from

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

BUG=
==========

to

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

BUG=
==========

[zino, 2017-05-25 18:08:50]

jinho.bang@samsung.com changed reviewers:
+ gogerald@chromium.org, rouslan@chromium.org

[zino, 2017-05-25 18:15:34]

rouslan@, in my previous CL[1], you thought that the PaymentAppRequest should be
renamed with other name (e.g. PaymentRequestEventData). Do you think that this
work is still worth?

If so, I'll send a review request for all reviewers.
Otherwise, I'll remove this CL and update follow-up CL[2].

[1] https://codereview.chromium.org/2887713002/
[2] https://codereview.chromium.org/2903643002/

Thank you!

[please use gerrit instead, 2017-05-25 19:02:58]

I will trust your judgement. What do you prefer?

[zino, 2017-06-02 16:26:19]

Description was changed from

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

BUG=
==========

to

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

In previous CL[1], the PaymentAppRequest was merged with PaymentRequestEvent
due to spec change. So, We need to change the name appropriately to fit the
current implementation.

[1] https://codereview.chromium.org/2887713002/

BUG=661608,720027
==========

[zino, 2017-06-02 16:30:01]

Description was changed from

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

In previous CL[1], the PaymentAppRequest was merged with PaymentRequestEvent
due to spec change. So, We need to change the name appropriately to fit the
current implementation.

[1] https://codereview.chromium.org/2887713002/

BUG=661608,720027
==========

to

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

In previous CL[1], the PaymentAppRequest was merged with PaymentRequestEvent
due to spec change. So, we need to change the name appropriately to fit the
current implementation.

[1] https://codereview.chromium.org/2887713002/

BUG=661608,720027
==========

[zino, 2017-06-02 16:30:01]

jinho.bang@samsung.com changed reviewers:
+ jochen@chromium.org, rsesek@chromium.org

[zino, 2017-06-02 16:31:53]

jinho.bang@samsung.com changed reviewers:
+ haraken@chromium.org

[zino, 2017-06-02 16:37:47]

PTAL

rouslan@, gogerald1@ for payments
(To avoid conflicts, I'll wait for landing Ganggui's openWindow CL)

haraken@ for blink

jochen@ for content

Robert Sesek@ for mojom

Thanks.

[please use gerrit instead, 2017-06-02 17:05:04]

Please put the spec link in the CL and note that this feature is behind the
chrome://flags/#enable-experimental-web-platform-features flag.

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/payments/PaymentRequestEventDataConversion.h
(right):

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestEventDataConversion.h:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
Either mark this 2017 or tune --similarity parameter to make "git cl upload"
detect this as a copy.

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequestEventInit.idl
(right):

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestEventInit.idl:5: //
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest
Update that link, please.

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/payments/WebPaymentRequestEventData.h
(right):

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/payments/WebPaymentRequestEventData.h:16:
// https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest
Update the link, please.

[zino, 2017-06-02 17:10:14]

Description was changed from

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

In previous CL[1], the PaymentAppRequest was merged with PaymentRequestEvent
due to spec change. So, we need to change the name appropriately to fit the
current implementation.

[1] https://codereview.chromium.org/2887713002/

BUG=661608,720027
==========

to

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

In previous CL[1], the PaymentAppRequest was merged with PaymentRequestEvent
due to spec change. So, we need to change the name appropriately to fit the
current implementation.

[1] https://codereview.chromium.org/2887713002/

Also, this feature is still behind runtime flag (PaymentApp).

The related spec link:
  https://w3c.github.io/payment-handler/

BUG=661608,720027
==========

[zino, 2017-06-02 17:10:32]

Description was changed from

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

In previous CL[1], the PaymentAppRequest was merged with PaymentRequestEvent
due to spec change. So, we need to change the name appropriately to fit the
current implementation.

[1] https://codereview.chromium.org/2887713002/

Also, this feature is still behind runtime flag (PaymentApp).

The related spec link:
  https://w3c.github.io/payment-handler/

BUG=661608,720027
==========

to

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

In previous CL[1], the PaymentAppRequest was merged with PaymentRequestEvent
due to spec change. So, we need to change the name appropriately to fit the
current implementation.

Also, this feature is still behind runtime flag (PaymentApp).

The related spec link:
  https://w3c.github.io/payment-handler/

[1] https://codereview.chromium.org/2887713002/

BUG=661608,720027
==========

[zino, 2017-06-02 17:23:49]

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/payments/PaymentRequestEventDataConversion.h
(right):

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestEventDataConversion.h:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/06/02 17:05:04, rouslan wrote:
> Either mark this 2017 or tune --similarity parameter to make "git cl upload"
> detect this as a copy.

Done.

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequestEventInit.idl
(right):

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequestEventInit.idl:5: //
https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest
On 2017/06/02 17:05:04, rouslan wrote:
> Update that link, please.

Done.

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/payments/WebPaymentRequestEventData.h
(right):

https://codereview.chromium.org/2898223002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/payments/WebPaymentRequestEventData.h:16:
// https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest
On 2017/06/02 17:05:04, rouslan wrote:
> Update the link, please.

Removed the link. The PaymentRequestEventData is internal value coming from
browser side.

[please use gerrit instead, 2017-06-02 17:34:09]

lgtm

[Robert Sesek, 2017-06-02 17:56:50]

mojom lgtm

[haraken, 2017-06-05 02:07:07]

LGTM

[zino, 2017-06-06 04:12:45]

jochen@, Gentle Ping :)

[jochen (gone - plz use gerrit), 2017-06-06 14:42:42]

lgtm

[gogerald1, 2017-06-06 14:50:36]

lgtm

[zino, 2017-06-06 14:54:33]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2017-06-06 14:54:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 17:23:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496760873467540,
"parent_rev": "92194f22fe5fa84643d10453040c85e228efe38f", "commit_rev":
"90eda5613ddc3a39a7ebcf94d110541385c60b9c"}

[commit-bot: I haz the power, 2017-06-06 17:23:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496760873467540,
"parent_rev": "838072e44f3a5d5856660d48837689d51eb18100", "commit_rev":
"745f3dff09793d3a5afe793a2599eadb341d2ee0"}

[commit-bot: I haz the power, 2017-06-06 17:24:06]

Description was changed from

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

In previous CL[1], the PaymentAppRequest was merged with PaymentRequestEvent
due to spec change. So, we need to change the name appropriately to fit the
current implementation.

Also, this feature is still behind runtime flag (PaymentApp).

The related spec link:
  https://w3c.github.io/payment-handler/

[1] https://codereview.chromium.org/2887713002/

BUG=661608,720027
==========

to

==========
PaymentHandler: Rename PaymentAppRequest with PaymentRequestEventData.

In previous CL[1], the PaymentAppRequest was merged with PaymentRequestEvent
due to spec change. So, we need to change the name appropriately to fit the
current implementation.

Also, this feature is still behind runtime flag (PaymentApp).

The related spec link:
  https://w3c.github.io/payment-handler/

[1] https://codereview.chromium.org/2887713002/

BUG=661608,720027

Review-Url: https://codereview.chromium.org/2898223002
Cr-Commit-Position: refs/heads/master@{#477316}
Committed:
https://chromium.googlesource.com/chromium/src/+/745f3dff09793d3a5afe793a2599...
==========

[commit-bot: I haz the power, 2017-06-06 17:24:09]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/745f3dff09793d3a5afe793a2599...