Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 2898203004: [Extensions] Remove "show button" UI from chrome://extensions (Closed)
Patch Set: Dan's Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index 81ec02f14c9b639dd1e7cf22f7cf61c5a490d14a..94d1f9042c4b748aa0b3570893f985d852b7dd39 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -22,7 +22,6 @@
#include "chrome/browser/extensions/api/developer_private/entry_picker.h"
#include "chrome/browser/extensions/api/developer_private/extension_info_generator.h"
#include "chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.h"
-#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
#include "chrome/browser/extensions/devtools_util.h"
#include "chrome/browser/extensions/extension_commands_global_registry.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -243,7 +242,6 @@ DeveloperPrivateEventRouter::DeveloperPrivateEventRouter(Profile* profile)
error_console_observer_(this),
process_manager_observer_(this),
app_window_registry_observer_(this),
- extension_action_api_observer_(this),
warning_service_observer_(this),
extension_prefs_observer_(this),
extension_management_observer_(this),
@@ -255,7 +253,6 @@ DeveloperPrivateEventRouter::DeveloperPrivateEventRouter(Profile* profile)
error_console_observer_.Add(ErrorConsole::Get(profile));
process_manager_observer_.Add(ProcessManager::Get(profile));
app_window_registry_observer_.Add(AppWindowRegistry::Get(profile));
- extension_action_api_observer_.Add(ExtensionActionAPI::Get(profile));
warning_service_observer_.Add(WarningService::Get(profile));
extension_prefs_observer_.Add(ExtensionPrefs::Get(profile));
extension_management_observer_.Add(
@@ -371,12 +368,6 @@ void DeveloperPrivateEventRouter::OnExtensionCommandRemoved(
extension_id);
}
-void DeveloperPrivateEventRouter::OnExtensionActionVisibilityChanged(
- const std::string& extension_id,
- bool is_now_visible) {
- BroadcastItemStateChanged(developer::EVENT_TYPE_PREFS_CHANGED, extension_id);
-}
-
void DeveloperPrivateEventRouter::OnExtensionDisableReasonsChanged(
const std::string& extension_id, int disable_reasons) {
BroadcastItemStateChanged(developer::EVENT_TYPE_PREFS_CHANGED, extension_id);
@@ -721,11 +712,6 @@ DeveloperPrivateUpdateExtensionConfigurationFunction::Run() {
}
modifier.SetAllowedOnAllUrls(*update.run_on_all_urls);
}
- if (update.show_action_button) {
- ExtensionActionAPI::Get(browser_context())->SetBrowserActionVisibility(
- extension->id(),
- *update.show_action_button);
- }
return RespondNow(NoArguments());
}

Powered by Google App Engine
This is Rietveld 408576698