chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 2898203004: [Extensions] Remove "show button" UI from chrome://extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 2898203004: [Extensions] Remove "show button" UI from chrome://extensions (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/api/developer_private/extension_info_generator.cc » ('j') | chrome/browser/extensions/api/developer_private/extension_info_generator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index 81ec02f14c9b639dd1e7cf22f7cf61c5a490d14a..522cb3ae83911b000c891d63e747c38eaf290c1a 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -721,11 +721,6 @@ DeveloperPrivateUpdateExtensionConfigurationFunction::Run() {

}

modifier.SetAllowedOnAllUrls(*update.run_on_all_urls);

}

- if (update.show_action_button) {

- ExtensionActionAPI::Get(browser_context())->SetBrowserActionVisibility(

- extension->id(),

- *update.show_action_button);

- }

return RespondNow(NoArguments());

}