Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2898173002: Adding Venafi 2nd Gen CT Log (Closed)

Created:
3 years, 7 months ago by Eran Messeri
Modified:
3 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, net-reviews_chromium.org, martijn+crwatch_martijnc.be
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Adding Venafi 2nd Gen CT Log Add the information about the Venafi 2nd generation CT log that recently passed compliance. This is a merge of the data approved in: https://bugs.chromium.org/p/chromium/issues/detail?id=688510#c18 It is not possible, unfortunately, to simply cherry-pick the original change (https://codereview.chromium.org/2874423002) because it depends on another change to operate correctly (https://chromium.googlesource.com/chromium/src/+/9657f6767718da315773bef39143c869508becc3), so cherry-picking fails. BUG=688510 R=rsleevi@chromium.org Review-Url: https://codereview.chromium.org/2898173002 . Cr-Commit-Position: refs/branch-heads/3071@{#682} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/519cff3570d4f9bc6e0041161c3bd9947218a5b7

Patch Set 1 #

Patch Set 2 : Adding Venafi 2nd Gen CT Log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M net/cert/ct_known_logs_static-inc.h View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Eran Messeri
Ryan, could you please review and make sure I'm landing the right thing on the ...
3 years, 7 months ago (2017-05-24 08:57:41 UTC) #3
Ryan Sleevi
LGTM You should be good to "git cl land" now
3 years, 7 months ago (2017-05-24 13:51:01 UTC) #4
Eran Messeri
Committed patchset #2 (id:20001) manually as 519cff3570d4f9bc6e0041161c3bd9947218a5b7 (presubmit successful).
3 years, 7 months ago (2017-05-24 13:56:06 UTC) #6
Eran Messeri
3 years, 7 months ago (2017-05-24 13:57:39 UTC) #7
Message was sent while issue was closed.
Thanks, Ryan!

for posterity, I'd had to:
git branch --set-upstream-to branch-heads/3071

before git-cl landing the change, since otherwise it complained about many
commits in the base branch that are not in this branch.

Powered by Google App Engine
This is Rietveld 408576698