Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2898093002: [Home] Don't show toolbar buttons until sheet is below 45% (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Don't show toolbar buttons until sheet is below 45% Wait to show the toolbar buttons until the sheet offset is less than 45%. 45% is used rather than 50% so that the buttons aren't shown in the half height state if the user is dragging the sheet down slowly and releases at exactly the half way point. BUG=725000, 695157 Review-Url: https://codereview.chromium.org/2898093002 Cr-Commit-Position: refs/heads/master@{#473895} Committed: https://chromium.googlesource.com/chromium/src/+/60f5de090496453f343c534d0fb1283d65450fc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Theresa
ptal
3 years, 7 months ago (2017-05-23 00:52:05 UTC) #3
mdjones
lgtm
3 years, 7 months ago (2017-05-23 01:27:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898093002/1
3 years, 7 months ago (2017-05-23 14:56:03 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 15:01:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/60f5de090496453f343c534d0fb1...

Powered by Google App Engine
This is Rietveld 408576698