Log the number of new icons created per jumplist update

Log the number of new icons created per jumplist update

This CL helps to validate the improvements led by the ongoing efforts in
removing redundant icon creation.

BUG=715902
Review-Url: https://codereview.chromium.org/2898083003
Cr-Commit-Position: refs/heads/master@{#474069}
Committed: https://chromium.googlesource.com/chromium/src/+/e1cdc972614971510f7de2672de8f782fd07385e

[chengx, 2017-05-23 01:05:37]

Description was changed from

==========
Merge branch 'master' of https://chromium.googlesource.com/chromium/src into
addiconcreatedmetric


Revert histograms.xml


Format obsolete tag in histograms.xml


Log the number of icons created per jumplist update

BUG=
==========

to

==========
Log the number of icons created per jumplist update

BUG=
==========

[chengx, 2017-05-23 01:05:46]

Patchset #1 (id:1) has been deleted

[chengx, 2017-05-23 01:14:48]

Description was changed from

==========
Log the number of icons created per jumplist update

BUG=
==========

to

==========
Log the number of new icons created per jumplist update

BUG=715902
==========

[chengx, 2017-05-23 01:17:32]

Patchset #1 (id:20001) has been deleted

[chengx, 2017-05-23 01:20:53]

Description was changed from

==========
Log the number of new icons created per jumplist update

BUG=715902
==========

to

==========
Log the number of new icons created per jumplist update

This CL helps to validate the improvements led by the ongoing efforts in
removing redundant icon creation.

BUG=715902
==========

[chengx, 2017-05-23 01:21:29]

The CQ bit was checked by chengx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 01:22:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 02:04:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 02:04:40]

Dry run: This issue passed the CQ dry run.

[chengx, 2017-05-23 05:01:45]

chengx@chromium.org changed reviewers:
+ grt@chromium.org

[chengx, 2017-05-23 05:01:46]

Hi Greg, this is the CL that logs the number of icons created per jumplist
update as promised. PTAL, thanks!

I was hesitating if I should create another UMA metric for this purpose, or just
reuse the existing "WinJumplist.CreateIconFilesCount". If ignoring the very
small amount of icons that are attempted but failed to create somehow,
"WinJumplist.CreateIconFilesCount" is right the number of icons created per
update.

Finally, I decided to reuse the existing "WinJumplist.CreateIconFilesCount".
Using one UMA metric across time makes it much easier to track the changes in
the number of icons created. Also, this metric will be removed by me in the near
future and nobody will pay attention to it anymore, so I think this small
approximation should be fine.

[grt (UTC plus 2), 2017-05-23 07:03:36]

lgtm with a nit

https://codereview.chromium.org/2898083003/diff/40001/chrome/browser/win/jump...
File chrome/browser/win/jumplist.cc (right):

https://codereview.chromium.org/2898083003/diff/40001/chrome/browser/win/jump...
chrome/browser/win/jumplist.cc:745: // Record the desired number of icons to
create in this JumpList update.
nit: update comment "Record the number of icons created in this JumpList
update."

[chengx, 2017-05-23 20:39:07]

The CQ bit was checked by chengx@chromium.org to run a CQ dry run

[chengx, 2017-05-23 20:39:39]

I've updated the comments in the new patch set. Thanks!

https://codereview.chromium.org/2898083003/diff/40001/chrome/browser/win/jump...
File chrome/browser/win/jumplist.cc (right):

https://codereview.chromium.org/2898083003/diff/40001/chrome/browser/win/jump...
chrome/browser/win/jumplist.cc:745: // Record the desired number of icons to
create in this JumpList update.
On 2017/05/23 07:03:36, grt (UTC plus 2) wrote:
> nit: update comment "Record the number of icons created in this JumpList
> update."

Done.

[commit-bot: I haz the power, 2017-05-23 20:40:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-05-23 21:07:26]

thanks. still lgtm!

[commit-bot: I haz the power, 2017-05-23 21:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 21:34:31]

Dry run: This issue passed the CQ dry run.

[chengx, 2017-05-23 21:37:14]

The CQ bit was checked by chengx@chromium.org

[commit-bot: I haz the power, 2017-05-23 21:38:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 21:44:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495575434574680,
"parent_rev": "a26cfa5ec070cc7f3da358d398f66ea234d44891", "commit_rev":
"e1cdc972614971510f7de2672de8f782fd07385e"}

[commit-bot: I haz the power, 2017-05-23 21:44:38]

Description was changed from

==========
Log the number of new icons created per jumplist update

This CL helps to validate the improvements led by the ongoing efforts in
removing redundant icon creation.

BUG=715902
==========

to

==========
Log the number of new icons created per jumplist update

This CL helps to validate the improvements led by the ongoing efforts in
removing redundant icon creation.

BUG=715902

Review-Url: https://codereview.chromium.org/2898083003
Cr-Commit-Position: refs/heads/master@{#474069}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1cdc972614971510f7de2672de8...
==========

[commit-bot: I haz the power, 2017-05-23 21:44:40]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e1cdc972614971510f7de2672de8...