Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2898023002: MD Settings: Fix omnibox search engine name misalignment. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix omnibox search engine name misalignment. BUG=724441 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2898023002 Cr-Commit-Position: refs/heads/master@{#473759} Committed: https://chromium.googlesource.com/chromium/src/+/c2931c53f2d672256b89ebcf133119e3608b9fef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dpapad
Before after screenshots: http://imgur.com/a/G2I5r
3 years, 7 months ago (2017-05-22 19:03:16 UTC) #3
dschuyler
lgtm
3 years, 7 months ago (2017-05-23 00:04:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898023002/1
3 years, 7 months ago (2017-05-23 00:13:41 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 00:19:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2931c53f2d672256b89ebcf1331...

Powered by Google App Engine
This is Rietveld 408576698