Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2898013003: [Chromedriver] Remove obsolete AddCookieScript. (Closed)

Created:
3 years, 7 months ago by gmanikpure
Modified:
3 years, 7 months ago
Reviewers:
johnchen, stgao
CC:
chromium-reviews, johnchen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Remove obsolete AddCookieScript. We are now using Devtools command Network.setCookie for adding cookies. BUG=chromedriver:1804 Review-Url: https://codereview.chromium.org/2898013003 Cr-Commit-Position: refs/heads/master@{#475153} Committed: https://chromium.googlesource.com/chromium/src/+/47ccd5118c3fadef30cfadc546897ca0aeb294fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -223 lines) Patch
M chrome/test/chromedriver/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/chromedriver/js/add_cookie.js View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/test/chromedriver/js/add_cookie_test.html View 1 chunk +0 lines, -127 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gmanikpure
Could you please take a look? Thanks.
3 years, 7 months ago (2017-05-22 20:47:21 UTC) #3
johnchen
lgtm
3 years, 7 months ago (2017-05-22 20:54:16 UTC) #4
stgao
lgtm
3 years, 7 months ago (2017-05-22 22:15:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898013003/1
3 years, 7 months ago (2017-05-26 20:16:29 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 22:01:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/47ccd5118c3fadef30cfadc54689...

Powered by Google App Engine
This is Rietveld 408576698