Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2898013002: [Telemetry] Fix imports for generate_system_health_csv (Closed)

Created:
3 years, 7 months ago by rnephew (Reviews Here)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix imports for generate_system_health_csv My recent changes to add StoryExpectations broke a tool. By adding an import this problem can be resolved. Traceback (most recent call last): <module> at /usr/local/google/code/clankium/src/tools/perf/generate_system_health_csv:13 import page_sets <module> at /usr/local/google/code/clankium/src/tools/perf/page_sets/__init__.py:18 base_classes = [story.StorySet, story.expectations.StoryExpectations] AttributeError: 'module' object has no attribute 'expectations' BUG=723783 Review-Url: https://codereview.chromium.org/2898013002 Cr-Commit-Position: refs/heads/master@{#473628} Committed: https://chromium.googlesource.com/chromium/src/+/67c4adc7f2a3ed20b86a7235df43d33c160aa0d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/perf/page_sets/__init__.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
rnephew (Reviews Here)
3 years, 7 months ago (2017-05-22 16:42:16 UTC) #3
nednguyen
lgtm
3 years, 7 months ago (2017-05-22 17:03:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898013002/1
3 years, 7 months ago (2017-05-22 17:25:52 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 18:25:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67c4adc7f2a3ed20b86a7235df43...

Powered by Google App Engine
This is Rietveld 408576698