Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2897993002: Detect frames from rotated devices in VideoTrackAdapter on Android. (Closed)

Created:
3 years, 7 months ago by Guido Urdaneta
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Detect frames from rotated devices in VideoTrackAdapter on Android. On Android, when a device is rotated, frames from the camera arrive with width and height swapped. The VideoTrackAdapter was unable to detect this and instead cropped them incorrectly because it treated the rotated dimension as a violation of the maximum size settings. This CL provides a simple mechanism to detect this problem on Android. If the frame arrives from the camera with width and height swapped from what was expected, treat it as a valid frame that does not need to be adjusted. BUG=718823 Review-Url: https://codereview.chromium.org/2870413004 Cr-Original-Commit-Position: refs/heads/master@{#472057} Review-Url: https://codereview.chromium.org/2897993002 . Cr-Commit-Position: refs/branch-heads/3071@{#652} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/a110813cbb7d0f8ff2395a6a4138183e97946ea5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -68 lines) Patch
M content/renderer/media/media_stream_constraints_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_constraints_util.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_constraints_util_unittest.cc View 24 chunks +82 lines, -23 lines 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_content.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_device.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_video_source.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_video_source_unittest.cc View 6 chunks +51 lines, -12 lines 0 comments Download
M content/renderer/media/media_stream_video_track_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/video_track_adapter.h View 2 chunks +14 lines, -6 lines 0 comments Download
M content/renderer/media/video_track_adapter.cc View 9 chunks +49 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Guido Urdaneta
3 years, 7 months ago (2017-05-22 15:43:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a110813cbb7d0f8ff2395a6a4138183e97946ea5.

Powered by Google App Engine
This is Rietveld 408576698