Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2897973002:
Hide Team Drives when user don't have membership of any Team Drive. (Closed)
|
Created:
3 years, 7 months ago by yamaguchi Modified:
3 years, 7 months ago Reviewers:
fukino CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionHide Team Drives when user don't have membership of any Team Drive.
BUG=723977
TEST=browser_tests --gtest_filter=FileManagerJsTest.DirectoryTree*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2897973002
Cr-Commit-Position: refs/heads/master@{#473788}
Committed: https://chromium.googlesource.com/chromium/src/+/47127ea9a7086fef5761809b90a45d1fd18f16e0
Patch Set 1 #
Total comments: 4
Patch Set 2 : Eliminate global/public functions #
Total comments: 6
Patch Set 3 : revise comments #
Messages
Total messages: 22 (15 generated)
Description was changed from ========== Hide Team Drives subtree when there is no accessible Team Drive entry. BUG=723977 TEST=browser_tests --gtest_filter=FileManagerJsTest.DirectoryTree* ========== to ========== Hide Team Drives subtree when there is no accessible Team Drive entry. BUG=723977 TEST=browser_tests --gtest_filter=FileManagerJsTest.DirectoryTree* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Hide Team Drives subtree when there is no accessible Team Drive entry. BUG=723977 TEST=browser_tests --gtest_filter=FileManagerJsTest.DirectoryTree* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Hide Team Drives when user don't have membership of any Team Drive. BUG=723977 TEST=browser_tests --gtest_filter=FileManagerJsTest.DirectoryTree* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
yamaguchi@chromium.org changed reviewers: + fukino@chromium.org
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2897973002/diff/1/ui/file_manager/file_manage... File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right): https://codereview.chromium.org/2897973002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:326: function IsNonEmptyDirectory(entry, callback) { Instead of defining this non-shared function in global namespace, could you move the contents (L327-330) to L759 in shouldShowTeamDrives? https://codereview.chromium.org/2897973002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:754: DriveVolumeItem.prototype.shouldShowTeamDrives = function(callback) { nit: Make this function private.
The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2897973002/diff/1/ui/file_manager/file_manage... File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right): https://codereview.chromium.org/2897973002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:326: function IsNonEmptyDirectory(entry, callback) { On 2017/05/23 00:47:02, fukino wrote: > Instead of defining this non-shared function in global namespace, could you move > the contents (L327-330) to L759 in shouldShowTeamDrives? Done. https://codereview.chromium.org/2897973002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:754: DriveVolumeItem.prototype.shouldShowTeamDrives = function(callback) { On 2017/05/23 00:47:02, fukino wrote: > nit: Make this function private. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with nits. https://codereview.chromium.org/2897973002/diff/20001/ui/file_manager/file_ma... File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right): https://codereview.chromium.org/2897973002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:743: * Checks whether the Team Drives node should be shown. nit: replaces "node" with "grand root" not to confuse it with other Team Drive roots. (and we use "node" very rarely) https://codereview.chromium.org/2897973002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:745: * true if it should show "Team Drives" node and its subtree. nit: 4 space indent. https://codereview.chromium.org/2897973002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:745: * true if it should show "Team Drives" node and its subtree. nit: replace "it" with "Files app". Ditto for "node"
https://codereview.chromium.org/2897973002/diff/20001/ui/file_manager/file_ma... File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right): https://codereview.chromium.org/2897973002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:743: * Checks whether the Team Drives node should be shown. On 2017/05/23 01:47:25, fukino wrote: > nit: replaces "node" with "grand root" not to confuse it with other Team Drive > roots. (and we use "node" very rarely) Done. https://codereview.chromium.org/2897973002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:745: * true if it should show "Team Drives" node and its subtree. On 2017/05/23 01:47:25, fukino wrote: > nit: replace "it" with "Files app". Ditto for "node" Done. https://codereview.chromium.org/2897973002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:745: * true if it should show "Team Drives" node and its subtree. On 2017/05/23 01:47:26, fukino wrote: > nit: 4 space indent. Done.
The CQ bit was checked by yamaguchi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org Link to the patchset: https://codereview.chromium.org/2897973002/#ps40001 (title: "revise comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495504704607100,
"parent_rev": "9c46717e8d85b283ccb79dd4e305d33ba99b1432", "commit_rev":
"47127ea9a7086fef5761809b90a45d1fd18f16e0"}
Message was sent while issue was closed.
Description was changed from ========== Hide Team Drives when user don't have membership of any Team Drive. BUG=723977 TEST=browser_tests --gtest_filter=FileManagerJsTest.DirectoryTree* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Hide Team Drives when user don't have membership of any Team Drive. BUG=723977 TEST=browser_tests --gtest_filter=FileManagerJsTest.DirectoryTree* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2897973002 Cr-Commit-Position: refs/heads/master@{#473788} Committed: https://chromium.googlesource.com/chromium/src/+/47127ea9a7086fef5761809b90a4... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/47127ea9a7086fef5761809b90a4... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
