Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2897963002:
Disable failing tests of cc_perftest suite on Android (Closed)
DescriptionDisable failing tests of cc_perftest suite on Android
The timed out tests are:
LayerTreeHostPerfTestJsonReader.HeavyPageThreaded
LayerTreeHostPerfTestJsonReader.TenTenSingleThread
LayerTreeHostPerfTestJsonReader.TenTenThreaded
LayerTreeHostPerfTestLeafInvalidates.TenTenThreaded
ScrollingLayerTreePerfTest.LongScrollablePageSingleThread
ScrollingLayerTreePerfTest.LongScrollablePageThreaded
BUG=723821
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2897963002
Cr-Commit-Position: refs/heads/master@{#473610}
Committed: https://chromium.googlesource.com/chromium/src/+/ec4fa85245ed85e99ac411cd8272b5163c6cc0f3
Patch Set 1 #Patch Set 2 : Update test disabling comments #Messages
Total messages: 21 (13 generated)
Description was changed from ========== Disable failing tests of cc_perftest suite on Android BUG=723821 ========== to ========== Disable failing tests of cc_perftest suite on Android BUG=723821 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
nednguyen@google.com changed reviewers: + danakj@chromium.org, enne@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
What's the failure here? Where are they crashing?
On 2017/05/22 16:58:24, enne wrote: > What's the failure here? Where are they crashing? Hi enne, they're timed out on Android bots (details in https://bugs.chromium.org/p/chromium/issues/detail?id=723821)
I saw the bug, but it wasn't very clear what the failure was, and the comments said crashing. Can you update the comments to say that they're timing out and not crashing?
On 2017/05/22 17:06:58, enne wrote: > I saw the bug, but it wasn't very clear what the failure was, and the comments > said crashing. > > Can you update the comments to say that they're timing out and not crashing? Done.
Description was changed from ========== Disable failing tests of cc_perftest suite on Android BUG=723821 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Disable failing tests of cc_perftest suite on Android The timed out tests are: LayerTreeHostPerfTestJsonReader.HeavyPageThreaded LayerTreeHostPerfTestJsonReader.TenTenSingleThread LayerTreeHostPerfTestJsonReader.TenTenThreaded LayerTreeHostPerfTestLeafInvalidates.TenTenThreaded ScrollingLayerTreePerfTest.LongScrollablePageSingleThread ScrollingLayerTreePerfTest.LongScrollablePageThreaded BUG=723821 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495473875736240,
"parent_rev": "188fc72030f13187af5cff7e9802f3abebdea017", "commit_rev":
"ec4fa85245ed85e99ac411cd8272b5163c6cc0f3"}
Message was sent while issue was closed.
Description was changed from ========== Disable failing tests of cc_perftest suite on Android The timed out tests are: LayerTreeHostPerfTestJsonReader.HeavyPageThreaded LayerTreeHostPerfTestJsonReader.TenTenSingleThread LayerTreeHostPerfTestJsonReader.TenTenThreaded LayerTreeHostPerfTestLeafInvalidates.TenTenThreaded ScrollingLayerTreePerfTest.LongScrollablePageSingleThread ScrollingLayerTreePerfTest.LongScrollablePageThreaded BUG=723821 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Disable failing tests of cc_perftest suite on Android The timed out tests are: LayerTreeHostPerfTestJsonReader.HeavyPageThreaded LayerTreeHostPerfTestJsonReader.TenTenSingleThread LayerTreeHostPerfTestJsonReader.TenTenThreaded LayerTreeHostPerfTestLeafInvalidates.TenTenThreaded ScrollingLayerTreePerfTest.LongScrollablePageSingleThread ScrollingLayerTreePerfTest.LongScrollablePageThreaded BUG=723821 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2897963002 Cr-Commit-Position: refs/heads/master@{#473610} Committed: https://chromium.googlesource.com/chromium/src/+/ec4fa85245ed85e99ac411cd8272... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ec4fa85245ed85e99ac411cd8272... |
