Support loading binary data in dart2js

Support loading binary data in dart2js

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/ebe69e6060ae36221ba2f876f02d6483e566b9a3

[Johnni Winther, 2017-05-22 10:38:53]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-22 22:21:36]

lgtm

https://codereview.chromium.org/2897903003/diff/1/pkg/compiler/lib/src/apiimp...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/2897903003/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:147: void reportReadError(exception) {
should we pull out this helper to reuse it with the function above?

https://codereview.chromium.org/2897903003/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:155: reporter.reportErrorMessage(node,
MessageKind.READ_SCRIPT_ERROR,
maybe "SCRIPT" is the wrong kind of word for the error in this context?

https://codereview.chromium.org/2897903003/diff/1/tests/compiler/dart2js/libr...
File tests/compiler/dart2js/library_resolution_test.dart (right):

https://codereview.chromium.org/2897903003/diff/1/tests/compiler/dart2js/libr...
tests/compiler/dart2js/library_resolution_test.dart:54: return (await
provider.readBytesFromUri(
nit, how about just updating 'uri' instead and calling readBytes once below?

if (uri == mockLibraryUri) {
  uri = Uri.parse('memory:mock1.dart');
} else if (uri == mock2LibraryUri) {
  uri = Uri.parse('memory:mock2.dart');
}
Input input = await provider.readBtesFromUri(uri, InputKind.utf8);
return input.data;

https://codereview.chromium.org/2897903003/diff/1/tests/compiler/dart2js/memo...
File tests/compiler/dart2js/memory_source_file_helper.dart (right):

https://codereview.chromium.org/2897903003/diff/1/tests/compiler/dart2js/memo...
tests/compiler/dart2js/memory_source_file_helper.dart:60: //Future<List<int>>
call(Uri resourceUri) => readBytesFromUri(resourceUri, InputKind.utf8);
delete?

[Johnni Winther, 2017-05-23 08:43:15]

https://codereview.chromium.org/2897903003/diff/1/pkg/compiler/lib/src/apiimp...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/2897903003/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:147: void reportReadError(exception) {
On 2017/05/22 22:21:36, Siggi Cherem (dart-lang) wrote:
> should we pull out this helper to reuse it with the function above?

Done.

https://codereview.chromium.org/2897903003/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:155: reporter.reportErrorMessage(node,
MessageKind.READ_SCRIPT_ERROR,
On 2017/05/22 22:21:36, Siggi Cherem (dart-lang) wrote:
> maybe "SCRIPT" is the wrong kind of word for the error in this context?
> 
> 

Renamed to READ_URI_ERROR.

https://codereview.chromium.org/2897903003/diff/1/tests/compiler/dart2js/libr...
File tests/compiler/dart2js/library_resolution_test.dart (right):

https://codereview.chromium.org/2897903003/diff/1/tests/compiler/dart2js/libr...
tests/compiler/dart2js/library_resolution_test.dart:54: return (await
provider.readBytesFromUri(
On 2017/05/22 22:21:36, Siggi Cherem (dart-lang) wrote:
> nit, how about just updating 'uri' instead and calling readBytes once below?
> 
> if (uri == mockLibraryUri) {
>   uri = Uri.parse('memory:mock1.dart');
> } else if (uri == mock2LibraryUri) {
>   uri = Uri.parse('memory:mock2.dart');
> }
> Input input = await provider.readBtesFromUri(uri, InputKind.utf8);
> return input.data;

Done.

[Johnni Winther, 2017-05-23 08:43:34]

Description was changed from

==========
Support loading binary data in dart2js
==========

to

==========
Support loading binary data in dart2js

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ebe69e6060ae36221ba2f876f02d6483e566b9a3
==========

[Johnni Winther, 2017-05-23 08:43:35]

Committed patchset #2 (id:20001) manually as
ebe69e6060ae36221ba2f876f02d6483e566b9a3 (presubmit successful).