Support loading binary data in dart2js

tests/compiler/dart2js/library_resolution_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Check that relative URIs are resolved against the canonical name of a
 /// library. This only matters for dart:-libraries, so this test mocks up two
 /// dart:-libraries.
 
 import "dart:io";
 
 import "dart:async";
 
 import "memory_source_file_helper.dart";
 
 import "package:async_helper/async_helper.dart";
 
 import 'package:expect/expect.dart' show Expect;
 
+import 'package:compiler/compiler_new.dart';
+
 import 'package:compiler/src/diagnostics/messages.dart'
     show MessageKind, MessageTemplate;
 
-import 'package:compiler/src/elements/elements.dart' show LibraryElement;
-
 import 'package:compiler/src/library_loader.dart' show LoadedLibraries;
 
 import 'package:compiler/src/null_compiler_output.dart' show NullCompilerOutput;
 
 import 'package:compiler/src/old_to_new_api.dart'
     show LegacyCompilerDiagnostics, LegacyCompilerInput;
 import 'package:compiler/src/options.dart' show CompilerOptions;
 
 Uri sdkRoot = Uri.base.resolve("sdk/");
 Uri mock1LibraryUri = sdkRoot.resolve("lib/mock1.dart");
 Uri mock2LibraryUri = sdkRoot.resolve("lib/mock2.dart");
 
 class CustomCompiler extends CompilerImpl {
   CustomCompiler(provider, handler, libraryRoot, packageConfig)
       : super(
             provider,
             const NullCompilerOutput(),
             handler,
             new CompilerOptions(
                 libraryRoot: libraryRoot, packageConfig: packageConfig));
 }
 
 main() async {
   Uri packageConfig = Uri.base.resolve('.packages');
 
   var provider = new MemorySourceFileProvider(MEMORY_SOURCE_FILES);
   var handler = new FormattingDiagnosticHandler(provider);
 
-  Future wrappedProvider(Uri uri) {
+  Future wrappedProvider(Uri uri) async {
     if (uri == mock1LibraryUri) {
-      return provider.readUtf8BytesFromUri(Uri.parse('memory:mock1.dart'));
+      return (await provider.readBytesFromUri(

[Siggi Cherem (dart-lang), 2017/05/22 22:21:36]

nit, how about just updating 'uri' instead and calling readBytes once below?

if (uri == mockLibraryUri) {
  uri = Uri.parse('memory:mock1.dart');
} else if (uri == mock2LibraryUri) {
  uri = Uri.parse('memory:mock2.dart');
}
Input input = await provider.readBtesFromUri(uri, InputKind.utf8);
return input.data;

[Johnni Winther, 2017/05/23 08:43:15]

Done.

+              Uri.parse('memory:mock1.dart'), InputKind.utf8))
+          .data;
     }
     if (uri == mock2LibraryUri) {
-      return provider.readUtf8BytesFromUri(Uri.parse('memory:mock2.dart'));
+      return (await provider.readBytesFromUri(
+              Uri.parse('memory:mock2.dart'), InputKind.utf8))
+          .data;
     }
-    return provider.readUtf8BytesFromUri(uri);
+    return (await provider.readBytesFromUri(uri, InputKind.utf8)).data;
   }
 
   String expectedMessage = MessageTemplate
       .TEMPLATES[MessageKind.LIBRARY_NOT_FOUND]
       .message({'resolvedUri': 'dart:mock2.dart'}).computeMessage();
 
   int actualMessageCount = 0;
 
   wrappedHandler(Uri uri, int begin, int end, String message, kind) {
     if (message == expectedMessage) {
@@ skipping 21 matching lines @@
   var libraries =
       await compiler.libraryLoader.loadLibrary(Uri.parse("dart:m_o_c_k_1"));
   await checkLibraries(libraries);
   asyncSuccess(null);
 }
 
 const Map MEMORY_SOURCE_FILES = const {
   "mock1.dart": "library mock1; import 'mock2.dart';",
   "mock2.dart": "library mock2;",
 };