Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2897903002: [Notifications] Fix swipe to close for ARC notifications. (Closed)

Created:
3 years, 7 months ago by yoshiki
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Notifications] Fix swipe to close for ARC notifications. Change ArcCustomNotificationView::EventForwarder to not directly invoke On*Event methods of ArcCustomNotificationView (which then call up to the parent). Instead, re-dispatch them to the containing widget, which should handle the event propagation, letting SlideOutController get events as it should. A consequence of this is that I had to add a delegate method to SlideOutController to update ArcCustomNotificationView::SlideHelper. This is because ArcCustomNotificationView will no longer get the gesture events, since it is no longer being called directly from EventForwarder. BUG=719407 Review-Url: https://codereview.chromium.org/2873553002 Cr-Commit-Position: refs/heads/master@{#473094} (cherry picked from commit 870290f623b47e436d231e354c84b8723bb7000a) Review-Url: https://codereview.chromium.org/2897903002 . Cr-Commit-Position: refs/branch-heads/3071@{#647} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/e33f895d0e3263a25c8e7cd114bfb793ea99fe83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -47 lines) Patch
M ui/arc/notification/arc_custom_notification_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 3 chunks +29 lines, -44 lines 0 comments Download
M ui/message_center/views/custom_notification_content_view_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/message_center/views/custom_notification_view.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view_unittest.cc View 5 chunks +99 lines, -0 lines 0 comments Download
M ui/message_center/views/message_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/message_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/views/slide_out_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/message_center/views/slide_out_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yoshiki
3 years, 7 months ago (2017-05-22 05:52:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e33f895d0e3263a25c8e7cd114bfb793ea99fe83.

Powered by Google App Engine
This is Rietveld 408576698