Chromium Code Reviews
Description[Notifications] Fix swipe to close for ARC notifications.
Change ArcCustomNotificationView::EventForwarder to not directly invoke On*Event methods of ArcCustomNotificationView (which then call up to the parent). Instead, re-dispatch them to the containing widget, which should handle the event propagation, letting SlideOutController get events as it should. A consequence of this is that I had to add a delegate method to SlideOutController to update ArcCustomNotificationView::SlideHelper. This is because ArcCustomNotificationView will no longer get the gesture events, since it is no longer being called directly from EventForwarder.
BUG=719407
Review-Url: https://codereview.chromium.org/2873553002
Cr-Commit-Position: refs/heads/master@{#473094}
(cherry picked from commit 870290f623b47e436d231e354c84b8723bb7000a)
Review-Url: https://codereview.chromium.org/2897903002 .
Cr-Commit-Position: refs/branch-heads/3071@{#647}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/e33f895d0e3263a25c8e7cd114bfb793ea99fe83
Patch Set 1 #Messages
Total messages: 2 (1 generated)
|