Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2897863003: Only show important sites dialog for cookies (Closed)

Created:
3 years, 7 months ago by dullweber
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only show important sites dialog for cookies The dialog should only be shown for cookies and not if just a cache deletion is selected. BUG=698692 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2897863003 Cr-Commit-Position: refs/heads/master@{#473843} Committed: https://chromium.googlesource.com/chromium/src/+/17d5597c638435b1b8fe60fe6e34da8dd7da3daa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
dullweber
Hi, we decided to show the important sites dialog only for cookies and not for ...
3 years, 7 months ago (2017-05-22 14:17:58 UTC) #3
Dan Beam
lgtm
3 years, 7 months ago (2017-05-22 18:09:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897863003/1
3 years, 7 months ago (2017-05-23 07:01:27 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 09:48:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17d5597c638435b1b8fe60fe6e34...

Powered by Google App Engine
This is Rietveld 408576698