[gin] Make a new IsolateHolder ctor for snapshot

Make a new IsolateHolder constructor to take snapshot with.

It instantiates v8::SnapshotCreator and SnapshotCreator creates
an isolate in its ctor.


BUG=617892
Review-Url: https://codereview.chromium.org/2897853002
Cr-Commit-Position: refs/heads/master@{#475548}
Committed: https://chromium.googlesource.com/chromium/src/+/da9d8be45f28dd326e79b9a15bffe0ab4bfd1858

[peria, 2017-05-22 04:43:16]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[peria, 2017-05-22 04:43:23]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-22 04:43:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-05-22 04:45:30]

Description was changed from

==========
Make isolate an argument to construct IsolateHolder

BUG=None
==========

to

==========
Make isolate an argument to construct IsolateHolder
To enable to set any isolate flexibly.


BUG=617892
==========

[commit-bot: I haz the power, 2017-05-22 04:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 04:54:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[peria, 2017-05-22 07:09:13]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[peria, 2017-05-22 07:09:19]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-05-22 07:09:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-05-22 07:23:12]

Description was changed from

==========
Make isolate an argument to construct IsolateHolder
To enable to set any isolate flexibly.


BUG=617892
==========

to

==========
Make isolate an argument to construct IsolateHolder.
To enable to set any isolate in a more flexible way.


BUG=617892
==========

[peria, 2017-05-22 07:25:12]

peria@chromium.org changed reviewers:
+ jochen@chromium.org

[peria, 2017-05-22 07:26:38]

peria@chromium.org changed reviewers:
+ haraken@chromium.org

[peria, 2017-05-22 07:30:50]

peria@chromium.org changed reviewers:
+ yzshen@chromium.org

[peria, 2017-05-22 07:30:51]

PTL.

As a background:
We will use a given isolate in taking a snapshot of V8 context
(crbug.com/617892), but current implementation does not allow to keep a given
isolate in IsolateHolder.

[peria, 2017-05-22 07:31:58]

Description was changed from

==========
Make isolate an argument to construct IsolateHolder.
To enable to set any isolate in a more flexible way.


BUG=617892
==========

to

==========
Make isolate an argument of IsolateHolder ctor.
To enable to set any isolate in a more flexible way.


BUG=617892
==========

[commit-bot: I haz the power, 2017-05-22 08:47:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 08:47:41]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-05-22 11:39:14]

Ideally, the lifetime of IsolateHolder and the v8::Isolate should be tightly
coupled. It seems to me that this patch goes in the opposite direction?

[peria, 2017-05-22 14:43:21]

On 2017/05/22 11:39:14, jochen wrote:
> Ideally, the lifetime of IsolateHolder and the v8::Isolate should be tightly
> coupled. It seems to me that this patch goes in the opposite direction?

Yes, I agree both.
On we create v8::SnapshotCreator, we have to use an isolate
(SnapshotCreator->isolate) instead of that created in IsolateHolder, and hence I
took this way.
Is it better to cache and inject isolates in blink::V8PerIsolate side?

[jochen (gone - plz use gerrit), 2017-05-23 07:14:37]

what about adding a static gin::IsolateHolder::CreateForSnapshot or similar?

[peria, 2017-05-30 02:56:54]

Sorry for late update. PTAL.


I create a new constructor for a given isolate.
V8PerIsolateData requires IsolateHolder as a member (not a pointer), so we need
this backdoor as a constructor.

[peria, 2017-05-30 03:05:30]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 03:05:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 04:43:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 04:43:32]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-05-30 11:51:14]

What about IsolateHolder::IsolateHolder(intptr_t* external_references,
v8::StartupData* existing_blob);?

[peria, 2017-05-30 13:44:39]

Description was changed from

==========
Make isolate an argument of IsolateHolder ctor.
To enable to set any isolate in a more flexible way.


BUG=617892
==========

to

==========
Make a new IsolateHolder constructor to take snapshot with.

It instantiates v8::SnapshotCreator and SnapshotCreator creates
an isolate in its ctor.


BUG=617892
==========

[peria, 2017-05-30 13:45:01]

On 2017/05/30 11:51:14, jochen wrote:
> What about IsolateHolder::IsolateHolder(intptr_t* external_references,
> v8::StartupData* existing_blob);?

Makes sense. done.

[jochen (gone - plz use gerrit), 2017-05-30 13:59:56]

lgtm

[peria, 2017-05-30 14:30:11]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2017-05-30 14:30:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 16:08:40]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496154611922990,
"parent_rev": "efe5baba2d156238707d6d8303b2055ddb246fe2", "commit_rev":
"da9d8be45f28dd326e79b9a15bffe0ab4bfd1858"}

[commit-bot: I haz the power, 2017-05-30 16:08:47]

Description was changed from

==========
Make a new IsolateHolder constructor to take snapshot with.

It instantiates v8::SnapshotCreator and SnapshotCreator creates
an isolate in its ctor.


BUG=617892
==========

to

==========
Make a new IsolateHolder constructor to take snapshot with.

It instantiates v8::SnapshotCreator and SnapshotCreator creates
an isolate in its ctor.


BUG=617892

Review-Url: https://codereview.chromium.org/2897853002
Cr-Commit-Position: refs/heads/master@{#475548}
Committed:
https://chromium.googlesource.com/chromium/src/+/da9d8be45f28dd326e79b9a15bff...
==========

[commit-bot: I haz the power, 2017-05-30 16:08:49]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/da9d8be45f28dd326e79b9a15bff...