Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2897813003: Add name of the enum to message to help looking up. (Closed)

Created:
3 years, 7 months ago by Junichi Uekawa
Modified:
3 years, 7 months ago
Reviewers:
xiyuan, fukino, kinaba
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add name of the enum to message to help looking up. I would like to have the error message itself but at least having the name to look up would be a plus. BUG=None TEST=ran with migration to get: [26113:26113:0522/140542.513399:ERROR:device_event_log_impl.cc(156)] [14:05:42.513] Login: homedir_methods.cc:414 HomedirMethods MountEx error (CryptohomeErrorCode): 29 [26113:26113:0522/140542.513532:ERROR:device_event_log_impl.cc(156)] [14:05:42.513] Login: cryptohome_authenticator.cc:909 Cryptohome failure: state(AuthState)=24, code(cryptohome::MountError)=128 Review-Url: https://codereview.chromium.org/2897813003 Cr-Commit-Position: refs/heads/master@{#473841} Committed: https://chromium.googlesource.com/chromium/src/+/3c1005eef79c0534edfec6a950839944a10054b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chromeos/cryptohome/homedir_methods.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Junichi Uekawa
Hi, I was wondering if the error messages had some keywords for better searching. (I ...
3 years, 7 months ago (2017-05-22 05:10:31 UTC) #2
kinaba
lgtm
3 years, 7 months ago (2017-05-22 05:43:40 UTC) #3
xiyuan
lgtm
3 years, 7 months ago (2017-05-22 17:21:56 UTC) #4
fukino
lgtm
3 years, 7 months ago (2017-05-23 07:48:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897813003/1
3 years, 7 months ago (2017-05-23 07:51:30 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 08:44:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c1005eef79c0534edfec6a95083...

Powered by Google App Engine
This is Rietveld 408576698