Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2897813002:
Allow data reduction proxy (DRP) warmup URL fetch to use cookies (Closed)
DescriptionAllow data reduction proxy (DRP) warmup URL fetch to use cookies
This allows the sessions setup for fetching the warmup URL to be
reused for fetching the user initiated requests.
Currently, with cookies disabled, the warmup URL is fetched over a
connection that has privacy mode enabled. This prevents the connection
to be reused for fetching the user initiated requests later.
BUG=725119
Review-Url: https://codereview.chromium.org/2897813002
Cr-Commit-Position: refs/heads/master@{#473618}
Committed: https://chromium.googlesource.com/chromium/src/+/3374eeb70e0834cffcf3a9723e8a67042ded551b
Patch Set 1 : ps #
Messages
Total messages: 21 (17 generated)
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Allow warmup URL fetch to use cookies BUG= ========== to ========== Allow data reduction proxy (DRP) warmup URL fetch to use cookies This allows the sessions setup for fetching the warmup URL to be reused for fetching the user initiated requests. BUG=672334 ==========
Description was changed from ========== Allow data reduction proxy (DRP) warmup URL fetch to use cookies This allows the sessions setup for fetching the warmup URL to be reused for fetching the user initiated requests. BUG=672334 ========== to ========== Allow data reduction proxy (DRP) warmup URL fetch to use cookies This allows the sessions setup for fetching the warmup URL to be reused for fetching the user initiated requests. Currently, with cookies disabled, the warmup URL is fetched over a connection that has privacy mode enabled. This prevents the connection to be reused for fetching the user initiated requests later. BUG=672334 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
tbansal@chromium.org changed reviewers: + ryansturm@chromium.org
ryansturm: ptal. Thanks.
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Allow data reduction proxy (DRP) warmup URL fetch to use cookies This allows the sessions setup for fetching the warmup URL to be reused for fetching the user initiated requests. Currently, with cookies disabled, the warmup URL is fetched over a connection that has privacy mode enabled. This prevents the connection to be reused for fetching the user initiated requests later. BUG=672334 ========== to ========== Allow data reduction proxy (DRP) warmup URL fetch to use cookies This allows the sessions setup for fetching the warmup URL to be reused for fetching the user initiated requests. Currently, with cookies disabled, the warmup URL is fetched over a connection that has privacy mode enabled. This prevents the connection to be reused for fetching the user initiated requests later. BUG=725119 ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495475333108070,
"parent_rev": "32600d88e079e01b8f6f67b10db4f548dedc54b9", "commit_rev":
"7a3c3a5e259b87f63e1c74e53b63ca948e38ab41"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495475333108070,
"parent_rev": "776023a087ef75be3994cb863aad523cdf5f92da", "commit_rev":
"3374eeb70e0834cffcf3a9723e8a67042ded551b"}
Message was sent while issue was closed.
Description was changed from ========== Allow data reduction proxy (DRP) warmup URL fetch to use cookies This allows the sessions setup for fetching the warmup URL to be reused for fetching the user initiated requests. Currently, with cookies disabled, the warmup URL is fetched over a connection that has privacy mode enabled. This prevents the connection to be reused for fetching the user initiated requests later. BUG=725119 ========== to ========== Allow data reduction proxy (DRP) warmup URL fetch to use cookies This allows the sessions setup for fetching the warmup URL to be reused for fetching the user initiated requests. Currently, with cookies disabled, the warmup URL is fetched over a connection that has privacy mode enabled. This prevents the connection to be reused for fetching the user initiated requests later. BUG=725119 Review-Url: https://codereview.chromium.org/2897813002 Cr-Commit-Position: refs/heads/master@{#473618} Committed: https://chromium.googlesource.com/chromium/src/+/3374eeb70e0834cffcf3a9723e8a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3374eeb70e0834cffcf3a9723e8a... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
