Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7426)

Unified Diff: chrome/browser/ui/webui/help/help_utils_chromeos.h

Issue 2897773002: Show proper message in about Chrome OS page (Closed)
Patch Set: Prevent updated status when dialog is shown Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/help/help_utils_chromeos.h
diff --git a/chrome/browser/ui/webui/help/help_utils_chromeos.h b/chrome/browser/ui/webui/help/help_utils_chromeos.h
index ab58c49b8096c69a223d1b708d08cfc51d84c9c0..7c6c14e3e2c8d4e500ba2c931b1e490888259f7a 100644
--- a/chrome/browser/ui/webui/help/help_utils_chromeos.h
+++ b/chrome/browser/ui/webui/help/help_utils_chromeos.h
@@ -11,8 +11,12 @@
namespace help_utils_chromeos {
-// Returns true if update over cellular networks is enabled.
-bool IsUpdateOverCellularAllowed();
+// Returns true if update over cellular networks is enabled. |interactive|
+// indicates whether the user is actively checking for update. By default, we
+// allow updates in Chrome UI if the user triggers the action (e.g clicking
+// a button) and leave the final decision as to whether to allow such updates
+// up to the update engine.
stevenjb 2017/05/22 22:57:32 This comment confused me until I examined the code
weidongg 2017/05/23 00:17:00 Sorry for the confusing comment. Thanks, this is m
+bool IsUpdateOverCellularAllowed(bool interactive);
// Returns localized name for the connection |type|.
base::string16 GetConnectionTypeAsUTF16(const std::string& type);

Powered by Google App Engine
This is Rietveld 408576698