Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2897773002: Show proper message in about Chrome OS page (Closed)

Created:
3 years, 7 months ago by weidongg
Modified:
3 years, 7 months ago
Reviewers:
xiyuan, stevenjb
CC:
chromium-reviews, alemate+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, achuith+watch_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Show proper message in about Chrome OS page - Background: Updates over cellular is blocked by Chrome UI by default, but we now allow so if user is actively checking for updates (e.g clicking 'check for updates' button). But auto-updates over cellular is still not supported. - Changes in this CL: Add a |interactive| parameter to IsUpdateOverCellularAllowed(), which indicates whether user is actively checking for updates. Show proper warning message when user is over cellular connection. - Design doc: go/cros-cellular-updates BUG=chromium:691108 TEST=go/about_chrome_os_err_msg for screenshots of different messages shown in different situations. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2897773002 Cr-Commit-Position: refs/heads/master@{#473953} Committed: https://chromium.googlesource.com/chromium/src/+/a02f7daa0abeca53945fe248847d955cae1a064a

Patch Set 1 #

Total comments: 8

Patch Set 2 : Apply fix to patch set 1 #

Patch Set 3 : Prevent updated status when dialog is shown #

Total comments: 12

Patch Set 4 : Apply fix to patch set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -38 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.js View 1 2 3 6 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_utils_chromeos.h View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/help_utils_chromeos.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.cc View 1 2 3 6 chunks +19 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/settings/about_handler.cc View 1 2 3 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
weidongg
xiyuan@chromium.org, stevenjb@chromium.org: Please review changes.
3 years, 7 months ago (2017-05-20 23:06:48 UTC) #5
xiyuan
https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js#newcode181 chrome/browser/resources/settings/about_page/about_page.js:181: this.hasCheckedForUpdates_ = false; Should this be moved to onUpdateWarningDialogClose_ ...
3 years, 7 months ago (2017-05-22 18:14:08 UTC) #12
weidongg
https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js#newcode181 chrome/browser/resources/settings/about_page/about_page.js:181: this.hasCheckedForUpdates_ = false; On 2017/05/22 18:14:08, xiyuan wrote: > ...
3 years, 7 months ago (2017-05-22 19:02:54 UTC) #13
xiyuan
https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js#newcode181 chrome/browser/resources/settings/about_page/about_page.js:181: this.hasCheckedForUpdates_ = false; On 2017/05/22 19:02:54, weidongg wrote: > ...
3 years, 7 months ago (2017-05-22 19:28:03 UTC) #14
weidongg
https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js#newcode181 chrome/browser/resources/settings/about_page/about_page.js:181: this.hasCheckedForUpdates_ = false; On 2017/05/22 19:28:03, xiyuan wrote: > ...
3 years, 7 months ago (2017-05-22 19:38:03 UTC) #15
xiyuan
https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js#newcode181 chrome/browser/resources/settings/about_page/about_page.js:181: this.hasCheckedForUpdates_ = false; On 2017/05/22 19:38:03, weidongg wrote: > ...
3 years, 7 months ago (2017-05-22 20:10:29 UTC) #16
weidongg
https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2897773002/diff/1/chrome/browser/resources/settings/about_page/about_page.js#newcode181 chrome/browser/resources/settings/about_page/about_page.js:181: this.hasCheckedForUpdates_ = false; On 2017/05/22 20:10:28, xiyuan wrote: > ...
3 years, 7 months ago (2017-05-22 21:13:26 UTC) #17
xiyuan
https://codereview.chromium.org/2897773002/diff/40001/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2897773002/diff/40001/chrome/browser/resources/settings/about_page/about_page.js#newcode232 chrome/browser/resources/settings/about_page/about_page.js:232: // dialog is shown. nit: can you combine the ...
3 years, 7 months ago (2017-05-22 22:36:34 UTC) #18
stevenjb
https://codereview.chromium.org/2897773002/diff/40001/chrome/browser/ui/webui/help/help_utils_chromeos.h File chrome/browser/ui/webui/help/help_utils_chromeos.h (right): https://codereview.chromium.org/2897773002/diff/40001/chrome/browser/ui/webui/help/help_utils_chromeos.h#newcode18 chrome/browser/ui/webui/help/help_utils_chromeos.h:18: // up to the update engine. This comment confused ...
3 years, 7 months ago (2017-05-22 22:57:32 UTC) #19
weidongg
https://codereview.chromium.org/2897773002/diff/40001/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2897773002/diff/40001/chrome/browser/resources/settings/about_page/about_page.js#newcode232 chrome/browser/resources/settings/about_page/about_page.js:232: // dialog is shown. On 2017/05/22 22:36:34, xiyuan wrote: ...
3 years, 7 months ago (2017-05-23 00:17:01 UTC) #20
stevenjb
lgtm
3 years, 7 months ago (2017-05-23 00:20:17 UTC) #21
xiyuan
lgtm
3 years, 7 months ago (2017-05-23 15:27:26 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897773002/60001
3 years, 7 months ago (2017-05-23 15:54:31 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 17:12:30 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a02f7daa0abeca53945fe248847d...

Powered by Google App Engine
This is Rietveld 408576698