Limit parallel download to http GET requests.

Limit parallel download to http GET requests.

Currently we have seen 405 error code in parallel download metrics.

And parallel download should be only used in GET requests since we
don't know how the server uses POST body data.

BUG=724690
Review-Url: https://codereview.chromium.org/2897743002
Cr-Commit-Position: refs/heads/master@{#474823}
Committed: https://chromium.googlesource.com/chromium/src/+/16ca9f743af85a9194b63b4585636d59b7c6bf53

[xingliu, 2017-05-19 23:27:58]

xingliu@chromium.org changed reviewers:
+ dtrainor@chromium.org, qinmin@chromium.org

[xingliu, 2017-05-19 23:27:58]

Hi, PTAL, thanks.

This is a fix based on metric analysis.

[xingliu, 2017-05-19 23:28:23]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 23:28:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 23:36:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 23:36:23]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[xingliu, 2017-05-20 00:35:06]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-20 00:35:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 04:03:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 04:03:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[David Trainor- moved to gerrit, 2017-05-22 21:15:14]

lgtm % nit

https://codereview.chromium.org/2897743002/diff/20001/content/browser/downloa...
File content/browser/download/download_job_factory.cc (right):

https://codereview.chromium.org/2897743002/diff/20001/content/browser/downloa...
content/browser/download/download_job_factory.cc:42:
net::HttpResponseInfo::CONNECTION_INFO_HTTP1_1;
Pull out to a pool.

[xingliu, 2017-05-22 21:21:45]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 21:22:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qinmin, 2017-05-22 21:24:50]

https://codereview.chromium.org/2897743002/diff/40001/content/browser/downloa...
File content/browser/download/download_job_factory.cc (right):

https://codereview.chromium.org/2897743002/diff/40001/content/browser/downloa...
content/browser/download/download_job_factory.cc:46: bool is_parallelizable =
has_strong_validator && create_info.accept_range &&
you need to add a new UMA enum for this

[xingliu, 2017-05-22 22:01:49]

xingliu@chromium.org changed reviewers:
+ isherman@chromium.org

[xingliu, 2017-05-22 22:01:50]

Added an enum for metric.

+isherman@, could you please take a look at change in enum.xml? thanks.

https://codereview.chromium.org/2897743002/diff/20001/content/browser/downloa...
File content/browser/download/download_job_factory.cc (right):

https://codereview.chromium.org/2897743002/diff/20001/content/browser/downloa...
content/browser/download/download_job_factory.cc:42:
net::HttpResponseInfo::CONNECTION_INFO_HTTP1_1;
On 2017/05/22 21:15:13, David Trainor-ping if over 24h wrote:
> Pull out to a pool.

Done.

https://codereview.chromium.org/2897743002/diff/40001/content/browser/downloa...
File content/browser/download/download_job_factory.cc (right):

https://codereview.chromium.org/2897743002/diff/40001/content/browser/downloa...
content/browser/download/download_job_factory.cc:46: bool is_parallelizable =
has_strong_validator && create_info.accept_range &&
On 2017/05/22 21:24:50, qinmin wrote:
> you need to add a new UMA enum for this

Done.

[xingliu, 2017-05-22 22:02:42]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 22:03:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-05-22 22:55:33]

On 2017/05/22 22:01:50, xingliu wrote:
> Added an enum for metric.
> 
> +isherman@, could you please take a look at change in enum.xml? thanks.

You don't need my review for the enums.xml change =)

[commit-bot: I haz the power, 2017-05-22 23:08:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:08:54]

Dry run: This issue passed the CQ dry run.

[qinmin, 2017-05-23 16:50:31]

lgtm

[xingliu, 2017-05-24 19:02:02]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 19:02:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 20:44:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 20:44:27]

Dry run: This issue passed the CQ dry run.

[xingliu, 2017-05-25 20:41:00]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2017-05-25 20:41:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2897743002/#ps80001
(title: "enum.xml.")

[commit-bot: I haz the power, 2017-05-25 20:41:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 22:32:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495744860878650,
"parent_rev": "f55799282c6b7a4f4748bb9bb7b899a9773d9a05", "commit_rev":
"16ca9f743af85a9194b63b4585636d59b7c6bf53"}

[commit-bot: I haz the power, 2017-05-25 22:33:08]

Description was changed from

==========
Limit parallel download to http GET requests.

Currently we have seen 405 error code in parallel download metrics.

And parallel download should be only used in GET requests since we
don't know how the server uses POST body data.

BUG=724690
==========

to

==========
Limit parallel download to http GET requests.

Currently we have seen 405 error code in parallel download metrics.

And parallel download should be only used in GET requests since we
don't know how the server uses POST body data.

BUG=724690

Review-Url: https://codereview.chromium.org/2897743002
Cr-Commit-Position: refs/heads/master@{#474823}
Committed:
https://chromium.googlesource.com/chromium/src/+/16ca9f743af85a9194b63b458563...
==========

[commit-bot: I haz the power, 2017-05-25 22:33:10]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/16ca9f743af85a9194b63b458563...