Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2897713002: DevTools: ResourceTreeModel should not report resources twice (Closed)

Created:
3 years, 7 months ago by lushnikov
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: ResourceTreeModel should not report resources twice Today, if one loads the page 'http://example.com', devtools will lack the main resource and thus will create one out of frame pyaload. However, in case of loading 'http://example.com/index.html', this is not necessary and results in reporting main resource twice. This patch fixes the issue, creating a fake resource only if it is not reported among frame resources. R=dgozman BUG=670180 Review-Url: https://codereview.chromium.org/2897713002 Cr-Commit-Position: refs/heads/master@{#473307} Committed: https://chromium.googlesource.com/chromium/src/+/ad816ae2af03119667c954d52cfcac88d084cf1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/iframe-main-resource.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/iframe-main-resource-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js View 2 chunks +6 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
lushnikov
please, take a look
3 years, 7 months ago (2017-05-19 18:37:37 UTC) #2
dgozman
lgtm
3 years, 7 months ago (2017-05-19 18:46:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897713002/1
3 years, 7 months ago (2017-05-19 18:56:50 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 20:54:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad816ae2af03119667c954d52cfc...

Powered by Google App Engine
This is Rietveld 408576698