Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2897673002: Return resources immediately after a Surface is destroyed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by Saman Sami
Modified:
5 months ago
Reviewers:
jbauman, piman
CC:
chromium-reviews, qsr+mojo_chromium.org, danakj+watch_chromium.org, viettrungluu+watch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, James Su, darin (slow to review), yusukes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Return resources immediately after a Surface is destroyed Make sure to return resources of a surface immediately once it's destroyed. Currently we have to wait until surface aggregation time. This caused memory leak in webview after a recent change. In this CL we notify cc::Display to release the resources through the SurfaceObserver interface. BUG=719379 TBR=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2897673002 Cr-Commit-Position: refs/heads/master@{#473904} Committed: https://chromium.googlesource.com/chromium/src/+/297c1e59895cf9d34e9cb1fe7d3c457a650ac97a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Check aggregator_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M cc/surfaces/compositor_frame_sink_support_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/display.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/display.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M cc/surfaces/surface_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/surfaces/surface_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/surfaces/surface_synchronization_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/viz/frame_sinks/mojo_frame_sink_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/viz/frame_sinks/mojo_frame_sink_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 26 (21 generated)
Saman Sami
5 months, 1 week ago (2017-05-19 18:31:23 UTC) #10
jbauman
lgtm with one nit. https://codereview.chromium.org/2897673002/diff/1/cc/surfaces/display.cc File cc/surfaces/display.cc (right): https://codereview.chromium.org/2897673002/diff/1/cc/surfaces/display.cc#newcode415 cc/surfaces/display.cc:415: void Display::OnSurfaceDiscarded(const SurfaceId& surface_id) { ...
5 months, 1 week ago (2017-05-19 21:07:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897673002/20001
5 months ago (2017-05-23 14:54:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897673002/20001
5 months ago (2017-05-23 15:03:52 UTC) #22
commit-bot: I haz the power
5 months ago (2017-05-23 15:17:52 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/297c1e59895cf9d34e9cb1fe7d3c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa