Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2897633002: Remove SetSelectedRange from ExpandSelectionToGranularity() (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
index 847e5eefc2226e0f4a018ff85ae6fc4228edbf9d..4898ebe492584f67141df52675ffe54d4246ef55 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
@@ -408,10 +408,12 @@ static bool ExpandSelectionToGranularity(LocalFrame& frame,
return false;
if (new_range.IsCollapsed())
return false;
- TextAffinity affinity = frame.Selection().GetSelectionInDOMTree().Affinity();
- frame.Selection().SetSelectedRange(new_range, affinity,
- SelectionDirectionalMode::kNonDirectional,
- FrameSelection::kCloseTyping);
+ frame.Selection().SetSelection(SelectionInDOMTree::Builder()
+ .SetBaseAndExtent(new_range)
+ .SetAffinity(VP_DEFAULT_AFFINITY)
yosin_UTC9 2017/05/22 04:59:44 nit: We don't need to call |SetAffinity(VP_DEFAULT
tanvir 2017/05/22 12:29:46 Done.
+ .SetIsDirectional(false)
yosin_UTC9 2017/05/22 04:59:43 nit: No need to call |SetIsDirectional()|. The def
tanvir 2017/05/22 12:29:46 Done.
+ .Build(),
+ FrameSelection::kCloseTyping);
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698