Generalize Active Setup triggering.

Generalize Active Setup triggering.

This is largely a rename of the OS_UPGRADES component to
SELECTIVE_TRIGGER. This makes it suitable for use with other features
that need to trigger active setup. It also resets all components to 0
when the major version is bumped.

BUG=717091
R=gab@chromium.org

Review-Url: https://codereview.chromium.org/2897593003
Cr-Commit-Position: refs/heads/master@{#474035}
Committed: https://chromium.googlesource.com/chromium/src/+/e02735002943e6b687a5d976ad1036fd600dd38d

[grt (UTC plus 2), 2017-05-19 20:57:47]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[grt (UTC plus 2), 2017-05-19 20:57:52]

PTAL

[commit-bot: I haz the power, 2017-05-19 20:59:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 21:27:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 21:27:34]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[grt (UTC plus 2), 2017-05-20 20:14:50]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-20 20:15:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 20:52:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 20:52:41]

Dry run: This issue passed the CQ dry run.

[gab, 2017-05-23 16:07:07]

lgtm % weird macros?

https://codereview.chromium.org/2897593003/diff/20001/chrome/installer/setup/...
File chrome/installer/setup/update_active_setup_version_work_item.cc (right):

https://codereview.chromium.org/2897593003/diff/20001/chrome/installer/setup/...
chrome/installer/setup/update_active_setup_version_work_item.cc:27: #define
AsChar16String(m) AsChar16String2(m)
?? How does that itoa?

[grt (UTC plus 2), 2017-05-23 19:46:03]

https://codereview.chromium.org/2897593003/diff/20001/chrome/installer/setup/...
File chrome/installer/setup/update_active_setup_version_work_item.cc (right):

https://codereview.chromium.org/2897593003/diff/20001/chrome/installer/setup/...
chrome/installer/setup/update_active_setup_version_work_item.cc:27: #define
AsChar16String(m) AsChar16String2(m)
On 2017/05/23 16:07:06, gab wrote:
> ?? How does that itoa?

It creates a string literal containing the expansion of the macro. The extra
level of indirection is needed due to the way macro substitution works.

[grt (UTC plus 2), 2017-05-23 19:46:11]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:46:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 20:24:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495568771906680,
"parent_rev": "44615d0da40054729d1b022273fbd6ab6eedbe8d", "commit_rev":
"e02735002943e6b687a5d976ad1036fd600dd38d"}

[commit-bot: I haz the power, 2017-05-23 20:24:23]

Description was changed from

==========
Generalize Active Setup triggering.

This is largely a rename of the OS_UPGRADES component to
SELECTIVE_TRIGGER. This makes it suitable for use with other features
that need to trigger active setup. It also resets all components to 0
when the major version is bumped.

BUG=717091
R=gab@chromium.org
==========

to

==========
Generalize Active Setup triggering.

This is largely a rename of the OS_UPGRADES component to
SELECTIVE_TRIGGER. This makes it suitable for use with other features
that need to trigger active setup. It also resets all components to 0
when the major version is bumped.

BUG=717091
R=gab@chromium.org

Review-Url: https://codereview.chromium.org/2897593003
Cr-Commit-Position: refs/heads/master@{#474035}
Committed:
https://chromium.googlesource.com/chromium/src/+/e02735002943e6b687a5d976ad10...
==========

[commit-bot: I haz the power, 2017-05-23 20:24:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e02735002943e6b687a5d976ad10...

[gab, 2017-05-23 22:09:50]

https://codereview.chromium.org/2897593003/diff/20001/chrome/installer/setup/...
File chrome/installer/setup/update_active_setup_version_work_item.cc (right):

https://codereview.chromium.org/2897593003/diff/20001/chrome/installer/setup/...
chrome/installer/setup/update_active_setup_version_work_item.cc:27: #define
AsChar16String(m) AsChar16String2(m)
On 2017/05/23 19:46:03, grt (UTC plus 2) wrote:
> On 2017/05/23 16:07:06, gab wrote:
> > ?? How does that itoa?
> 
> It creates a string literal containing the expansion of the macro. The extra
> level of indirection is needed due to the way macro substitution works.

Interesting... how does that get the quotes in place?!

https://codereview.chromium.org/2897593003/diff/20001/chrome/installer/setup/...
chrome/installer/setup/update_active_setup_version_work_item.cc:33: #undef
AsString2
#undef is undefining wrong thing

[grt (UTC plus 2), 2017-05-24 12:00:39]

https://codereview.chromium.org/2897593003/diff/20001/chrome/installer/setup/...
File chrome/installer/setup/update_active_setup_version_work_item.cc (right):

https://codereview.chromium.org/2897593003/diff/20001/chrome/installer/setup/...
chrome/installer/setup/update_active_setup_version_work_item.cc:27: #define
AsChar16String(m) AsChar16String2(m)
On 2017/05/23 22:09:50, gab wrote:
> On 2017/05/23 19:46:03, grt (UTC plus 2) wrote:
> > On 2017/05/23 16:07:06, gab wrote:
> > > ?? How does that itoa?
> > 
> > It creates a string literal containing the expansion of the macro. The extra
> > level of indirection is needed due to the way macro substitution works.
> 
> Interesting... how does that get the quotes in place?!

The # operator:
http://en.cppreference.com/w/cpp/preprocessor/replace#.23_and_.23.23_operators

https://codereview.chromium.org/2897593003/diff/20001/chrome/installer/setup/...
chrome/installer/setup/update_active_setup_version_work_item.cc:33: #undef
AsString2
On 2017/05/23 22:09:50, gab wrote:
> #undef is undefining wrong thing

Ooops. Fixing in a followon CL.