Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2897573002:
remove offline check (Closed)
|
Created:
3 years, 7 months ago by renjieliu1 Modified:
3 years, 7 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove offline check.
As it caused if there's cache, even translation succeeded it will still
reports failure. :(
We will revisit the fix after googleo@'s refactoring.
BUG=724355
Review-Url: https://codereview.chromium.org/2897573002
Cr-Commit-Position: refs/heads/master@{#473742}
Committed: https://chromium.googlesource.com/chromium/src/+/8d5f674e5ca5d6a9f0a2a9163bdba3615b2a83dd
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
Description was changed from ========== remove offline check BUG=724355 ========== to ========== Remove offline check. As it caused if there's cache, even translation succeeded it will still reports failure. :( We will revisit the fix after googleo@'s refactoring. BUG=724355 ==========
renjieliu@chromium.org changed reviewers: + googleo@chromium.org, groby@chromium.org, napper@chromium.org
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for the fixed. my cl https://codereview.chromium.org/2894553002/ is in reviewing, which will remove the relationship between driver and infobar
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by renjieliu@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495495443671290, "parent_rev":
"764476c65b8205086820a5ea02c10a645d6a0518", "commit_rev":
"8d5f674e5ca5d6a9f0a2a9163bdba3615b2a83dd"}
Message was sent while issue was closed.
Description was changed from ========== Remove offline check. As it caused if there's cache, even translation succeeded it will still reports failure. :( We will revisit the fix after googleo@'s refactoring. BUG=724355 ========== to ========== Remove offline check. As it caused if there's cache, even translation succeeded it will still reports failure. :( We will revisit the fix after googleo@'s refactoring. BUG=724355 Review-Url: https://codereview.chromium.org/2897573002 Cr-Commit-Position: refs/heads/master@{#473742} Committed: https://chromium.googlesource.com/chromium/src/+/8d5f674e5ca5d6a9f0a2a9163bdb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8d5f674e5ca5d6a9f0a2a9163bdb... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
